fix(USB): increase socket buffer and handle panic#2710
Merged
Conversation
Signed-off-by: Aryan Bakliwal <[email protected]>
charankamal20
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:

This PR fixes a hard crash (
slice bounds out of range [:-1]) in the USBDeviceHandler that occurs when the kernel's Netlink event queue overflows.When the default Netlink socket receive buffer fills up,
unix.Recvfromreturns theENOBUFS(No buffer space available) error and -1 for the number of bytes read (nr).Because the loop previously logged the error but did not continue to the next iteration, the code attempted to slice the buffer with the negative index, resulting in a panic.
Fixes #
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered:

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>