docs(getting-started): Update nodeSelector hostname label matching#2678
Merged
Aryan-sharma11 merged 3 commits intoJun 22, 2026
Merged
Conversation
kanishksingh23
force-pushed
the
docs/update-nodeselector-hostname-labels
branch
from
1026ff5 to
9fa13ae
Compare
AryanBakliwal
left a comment
AryanBakliwal
left a comment
Member
There was a problem hiding this comment.
Hey @kanishksingh23, the changes are correct but verbose in their current state. Can we try to summarize the newly added docs a bit.
kanishksingh23
force-pushed
the
docs/update-nodeselector-hostname-labels
branch
from
fa93ed7 to
5e4ef2e
Compare
Contributor
Author
|
Hey @AryanBakliwal, thanks for the feedback. I have updated the docs to be more concise. Please have a look. |
AryanBakliwal
requested changes
Jun 18, 2026
Signed-off-by: kanishksingh23 <[email protected]>
kanishksingh23
force-pushed
the
docs/update-nodeselector-hostname-labels
branch
from
deff8f5 to
a8e30c4
Compare
Aryan-sharma11
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR:
Fixes #2669
Does this PR introduce a breaking change?
NO
If the changes in this PR are manually verified, list down the scenarios covered:
Verified that all 4 hostname matching modes documented match the implementation
in KubeArmor/common/common.go added by #2640
Additional information for reviewer? :
This PR is a continuation of #2640, which added improved hostname policy matching
but did not update the docs.
Checklist:
<type>(<scope>): <subject>