fix(ci): install protoc binary in ci-test-systemd workflow#2605
Merged
rksharma95 merged 1 commit intoMay 27, 2026
Merged
Conversation
Athang69
force-pushed
the
fix/ci-test-systemd-install-protoc
branch
from
180859d to
e7d863b
Compare
There was a problem hiding this comment.
Pull request overview
Fixes the ci-test-systemd GitHub Actions workflow by installing the protoc compiler binary (which the protobuf/Makefile invokes directly) and ensuring the Go bin directory is on PATH so the Go protoc plugins are discoverable during make local-release.
Changes:
- Install
protobuf-compilervia apt in theInstall protocstep. - Append
$(go env GOPATH)/binto$GITHUB_PATHsoprotoc-gen-goandprotoc-gen-go-grpcare on PATH.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Athang69
force-pushed
the
fix/ci-test-systemd-install-protoc
branch
from
e7d863b to
b33b634
Compare
7 tasks
Contributor
Author
|
@rksharma95 @Aryan-sharma11 this PR adresses the failing CI test PTAL. |
7 tasks
achrefbensaad
approved these changes
May 22, 2026
rksharma95
approved these changes
May 22, 2026
achrefbensaad
force-pushed
the
fix/ci-test-systemd-install-protoc
branch
from
b33b634 to
a87adc1
Compare
Contributor
Author
|
@Aryan-sharma11 @AryanBakliwal PTAL whenever convenient. |
Signed-off-by: Athang69 <[email protected]>
AryanBakliwal
force-pushed
the
fix/ci-test-systemd-install-protoc
branch
from
a87adc1 to
40afaf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #2604
The
Install protocstep inci-test-systemd.ymlinstalls only the Go protoc plugins (protoc-gen-go,protoc-gen-go-grpc) viago installbut does not install theprotoccompiler binary itself. Whenmake local-releaseruns and invokesprotobuf/Makefile, it fails withprotoc: No such file or directory(exit 127). This fix installsprotobuf-compilervia apt and adds the Go bin directory to PATH so bothprotocand the Go plugins are available on the runner.Does this PR introduce a breaking change?
No.
If the changes in this PR are manually verified, list down the scenarios covered:
mainby runninggit show origin/main:.github/workflows/ci-test-systemd.ymland verifying the missingapt-get install protobuf-compilerprotoc: No such file or directoryat themake -C ../protobufstepAdditional information for reviewer?
This is a standalone bug fix unrelated to any other open PR. The failure is reproducible on any push to
maintouchingKubeArmor/**,tests/**, orprotobuf/**.Checklist:
<type>(<scope>): <subject>