fix(helm): add gkeAllowlistVersion flag to allow #2582
Merged
rksharma95 merged 1 commit intoMay 19, 2026
Merged
Conversation
rksharma95
approved these changes
May 8, 2026
Collaborator
|
@achrefbensaad PTAL, with this flag we'll be able to configure the compatible workloadallowlist version. |
Signed-off-by: charankamal20 <[email protected]>
rksharma95
force-pushed
the
bugfix/gke-allowlist-version
branch
from
af2b7ac to
b990ae2
Compare
achrefbensaad
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #
Added gkeAllowlistVersion: "" flag in values.yaml
If gkeAllowlistVersion is non-empty -> uses that value
If gkeAllowlistVersion is empty (default) -> falls back to chart.majorMinorVersion
The | default "" pipe ensures it handles the case where the key is missing entirely, not just empty.
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>