Skip to content

Commit 66b540c

Browse files
committed
apacheGH-3817: Pass the chunker through the existing column writer constructors
The column writers are package private, so their constructors can take the chunker instead of gaining overloads that leave the old ones unused.
1 parent ef414ba commit 66b540c

3 files changed

Lines changed: 1 addition & 25 deletions

File tree

‎parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriterBase.java‎

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,7 @@ abstract class ColumnWriterBase implements ColumnWriter {
6363
private final ContentDefinedChunker chunker;
6464

6565
ColumnWriterBase(ColumnDescriptor path, PageWriter pageWriter, ParquetProperties props) {
66-
this(path, pageWriter, null, props);
67-
}
68-
69-
ColumnWriterBase(
70-
ColumnDescriptor path,
71-
PageWriter pageWriter,
72-
BloomFilterWriter bloomFilterWriter,
73-
ParquetProperties props) {
74-
this(path, pageWriter, bloomFilterWriter, ContentDefinedChunker.noop(), props);
66+
this(path, pageWriter, null, ContentDefinedChunker.noop(), props);
7567
}
7668

7769
ColumnWriterBase(

‎parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriterV1.java‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,6 @@ final class ColumnWriterV1 extends ColumnWriterBase {
4040
}
4141

4242
public ColumnWriterV1(
43-
ColumnDescriptor path,
44-
PageWriter pageWriter,
45-
BloomFilterWriter bloomFilterWriter,
46-
ParquetProperties props) {
47-
super(path, pageWriter, bloomFilterWriter, props);
48-
}
49-
50-
ColumnWriterV1(
5143
ColumnDescriptor path,
5244
PageWriter pageWriter,
5345
BloomFilterWriter bloomFilterWriter,

‎parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriterV2.java‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,6 @@ public BytesInput getBytes() {
6161
super(path, pageWriter, props);
6262
}
6363

64-
ColumnWriterV2(
65-
ColumnDescriptor path,
66-
PageWriter pageWriter,
67-
BloomFilterWriter bloomFilterWriter,
68-
ParquetProperties props) {
69-
super(path, pageWriter, bloomFilterWriter, props);
70-
}
71-
7264
ColumnWriterV2(
7365
ColumnDescriptor path,
7466
PageWriter pageWriter,

0 commit comments

Comments
 (0)