Skip to content

C++ crash hook fixes#379

Merged
kstenerud merged 4 commits into
kstenerud:masterfrom
GLinnik21:master
Jun 24, 2020
Merged

C++ crash hook fixes#379
kstenerud merged 4 commits into
kstenerud:masterfrom
GLinnik21:master

Conversation

@GLinnik21

Copy link
Copy Markdown
Collaborator

Prevented tail call optimisation to gain constant stack frames number in backtrace.

@GLinnik21

Copy link
Copy Markdown
Collaborator Author

@kstenerud what do you think about -fno-optimize-sibling-calls compiler flag?
TCO also affected kssc_initSelfThread->kssc_initWithBacktrace calls previously.

@kstenerud

Copy link
Copy Markdown
Owner

Yup, don't see any problems with that. KSCrash itself doesn't need optimize-at-all-costs since it's never going to be the critical path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants