Support embedding a 3.7 broker#262
Merged
robobario merged 1 commit intokroxylicious:mainfrom Jan 12, 2024
Merged
Conversation
robobario
force-pushed
the
kafka-37-backwards-compat
branch
from
eb7ec9c to
cfaafdb
Compare
robobario
commented
Jan 12, 2024
robobario
force-pushed
the
kafka-37-backwards-compat
branch
2 times, most recently
from
7681985 to
9202bdb
Compare
SamBarker
approved these changes
Jan 12, 2024
Member
SamBarker
left a comment
SamBarker
left a comment
There was a problem hiding this comment.
Nasty but I'm not sure what else to suggest.
Thanks @robobario
Member
Author
|
Have tested against the strimzi 3.7 PR branch by running the |
tombentley
approved these changes
Jan 12, 2024
robobario
force-pushed
the
kafka-37-backwards-compat
branch
from
9202bdb to
c25b467
Compare
|
Why: In Kafka 3.7 the MetaProperties has changed package, so the extension fails with an exception at Runtime when it tries to invoke buildMetadataProperties if we have the 3.7 kafka server on the classpath. This change will be required when we upgrade the extension to compile against 3.7 to support backwards compatibility with Kafka 3.6
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Why:
In Kafka 3.7 the MetaProperties has changed package, so the extension fails with an exception at Runtime when it tries to invoke buildMetadataProperties if we have the 3.7 kafka server on the classpath.
This change will be required when we upgrade the extension to compile against 3.7 to support backwards compatibility with Kafka 3.6
Additional Context
Strimzi are preparing to use Kafka 3.7 and this breaks their tests at runtime as we can no longer start up embedded brokers.
Checklist
Please go through this checklist and make sure all applicable tasks have been done