Repository navigation
Commit 72c5f91
Fix alias_dsn detection for --list-dsn and -D (dbcli#1617)
* Fix alias_dsn detection for --list-dsn and -D
--list-dsn and -D/--dsn read the config with a bare load_config that skips
the packaged default, unlike the rest of pgcli. On a fresh install (config
not written yet) --list-dsn hit a KeyError on the missing [alias_dsn]
section and printed a misleading "Invalid DSNs found" error, and -D could
crash on the missing [main] section when the user config only had an
[alias_dsn] block. Load config via get_config instead, which writes the
default template if needed and always carries the expected sections.
Fixes dbcli#1489
* Make --list-dsn and -D resolve aliases without writing the config
---------
Co-authored-by: Chris (ChrisJr404) <[email protected]>
Co-authored-by: Irina Truong <[email protected]>1 parent a6ced25 commit 72c5f91
3 files changed
Lines changed: 106 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
44 | 50 | | |
45 | 51 | | |
46 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1706 | 1706 | | |
1707 | 1707 | | |
1708 | 1708 | | |
| 1709 | + | |
| 1710 | + | |
| 1711 | + | |
| 1712 | + | |
| 1713 | + | |
1709 | 1714 | | |
1710 | | - | |
1711 | | - | |
| 1715 | + | |
| 1716 | + | |
1712 | 1717 | | |
1713 | 1718 | | |
1714 | 1719 | | |
| |||
1777 | 1782 | | |
1778 | 1783 | | |
1779 | 1784 | | |
1780 | | - | |
| 1785 | + | |
| 1786 | + | |
| 1787 | + | |
1781 | 1788 | | |
1782 | 1789 | | |
1783 | 1790 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
0 commit comments