[DIAGNOSTIC - do not merge] Locate the Windows worker-thread teardown AV#380
Closed
realFlowControl wants to merge 1 commit into
Closed
[DIAGNOSTIC - do not merge] Locate the Windows worker-thread teardown AV#380realFlowControl wants to merge 1 commit into
realFlowControl wants to merge 1 commit into
Conversation
Throwaway instrumentation to locate the latent teardown access violation in functional/007 (and any other test) that the catch-all VEH masks. On a non-undefined-function AV on a worker thread, capture a symbolized native backtrace (dbghelp) plus the PHP file/line and print to stdout, then keep the existing zend_bailout() behaviour. Not for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway branch to find the root cause of the latent worker-thread access violation that the catch-all VEH (from #355) masks, surfaced by #379.
Instruments the existing catch-all VEH: on a non-undefined-function access violation on a worker thread, capture a symbolized native backtrace (
dbghelp, pulled in via#pragma comment(lib, ...)so no build-config change) plus the PHP file/line, print to stdout, then keep the existingzend_bailout(). Printing to stdout breaks the affected tests'--EXPECT--, so the backtrace shows up in their failure diff in the Windows CI log.Not for merge — purely to read the backtrace from Windows CI.