Repository navigation
test: cover shell quoting and sanitize helpers - #152
Merged
Merged
Conversation
5 tasks
muhtalipdede
requested changes
Aug 12, 2026
muhtalipdede
left a comment
muhtalipdede
left a comment
Member
There was a problem hiding this comment.
Review
Thanks for picking up #109 — direction is right (shellQuote table + Argo sanitize coverage is the valuable part).
Blocking
- Rebase onto
main— this branch is ~50 commits behind and currentlymergeable_state: dirty. - Duplicate generate-path test —
mainalready hasTestGeneratePipelineRunQuotesInjectionShapedRepo(with$(…)-shaped repo + clone/echo asserts). After rebase, drop or merge your variant into that existing test rather than adding a second same-named case. Keep the newTestShellQuoteand Argo sanitize tests.
Non-blocking
TestSanitizeTemplateNameis thin; an empty-input →"main"case would match the workflow-name coverage style.- As a first-time contributor, full
ci/ CodeQL may need a maintainer workflow approval after the rebase — happy to kick that once conflicts are gone.
Happy to approve once rebased and green.
fredrikblau
force-pushed
the
issue-109-tests
branch
from
August 12, 2026 21:26
e175b49 to
ff8d796
Compare
Author
|
Rebased onto current
Validation: |
muhtalipdede
approved these changes
Aug 13, 2026
muhtalipdede
left a comment
muhtalipdede
left a comment
Member
There was a problem hiding this comment.
Review
Thanks for the rebase — previous concerns addressed.
- Duplicate Tekton generate-path test dropped; upstream SEC-006 coverage preserved
TestShellQuotetable is solid- Argo sanitize coverage + empty →
mainfor template name looks good
LGTM for #109.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shellQuoteedge casesTesting
GOPROXY=direct go test ./internal/tools/argo ./internal/tools/tektonFixes #109