Skip to content

tomli was merged under the name tomllib into std library *3.11*#3088

Merged
koxudaxi merged 2 commits intokoxudaxi:mainfrom
a-detiste:main
Apr 16, 2026
Merged

tomli was merged under the name tomllib into std library *3.11*#3088
koxudaxi merged 2 commits intokoxudaxi:mainfrom
a-detiste:main

Conversation

@a-detiste
Copy link
Copy Markdown
Contributor

@a-detiste a-detiste commented Apr 15, 2026 •
edited by coderabbitai Bot
Loading

Hi,

There is a little of-by-one error in the dependencies metadata.

This is important on Debian when we try to remove old tomli usage
and the cut-off Python version to drop optional dependencies is precisely 3.11

https://salsa.debian.org/python-team/tools/dh-python/-/commit/14e4e6a8ae63c9918732599393f6f28d1130d3bd

https://docs.python.org/3/library/tomllib.html

Summary by CodeRabbit

  • Chores
    • Updated dependency version compatibility constraints to refine Python version support.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock, !**/*.lock and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f7be4291-4e62-467b-a43f-a7d4237d771b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The pyproject.toml file's conditional dependency marker for tomli was updated to use a stricter comparison operator, excluding Python 3.11 from the automatic inclusion of this package.

Changes

Cohort / File(s) Summary
Dependency Constraint Update
pyproject.toml		 Updated tomli dependency marker from python_version<='3.11' to python_version<'3.11', changing the condition to exclude Python 3.11 from requiring the package.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A single character hops away,
From equal-or-less to less-than's way,
Python 3.11 stands alone,
No tomli needed in its home! 🌾

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately identifies the core issue: tomli was merged as tomllib into Python 3.11's standard library, which directly justifies the dependency marker change from '<=' to '<'.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 16, 2026 •
edited
Loading

Merging this PR will improve performance by 18.37%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 11 improved benchmarks
⏩ 98 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ WallTime test_perf_duplicate_names 1,098.4 ms 940.3 ms +16.81%
⚡ WallTime test_perf_complex_refs 2.3 s 1.9 s +18.37%
⚡ WallTime test_perf_deep_nested 6.3 s 5.5 s +14.91%
⚡ WallTime test_perf_multiple_files_input 3.9 s 3.3 s +17.75%
⚡ WallTime test_perf_kubernetes_style_pydantic_v2 2.7 s 2.4 s +14.44%
⚡ WallTime test_perf_graphql_style_pydantic_v2 856.1 ms 740.3 ms +15.65%
⚡ WallTime test_perf_stripe_style_pydantic_v2 2.1 s 1.8 s +13.86%
⚡ WallTime test_perf_openapi_large 3 s 2.6 s +16.78%
⚡ WallTime test_perf_aws_style_openapi_pydantic_v2 2 s 1.7 s +15.99%
⚡ WallTime test_perf_large_models_pydantic_v2 3.8 s 3.3 s +16.66%
⚡ WallTime test_perf_all_options_enabled 6.8 s 5.9 s +15.57%

Comparing a-detiste:main (09425f3) with main (d7a1f71)

Open in CodSpeed

Footnotes

  1. 98 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d7a1f71) to head (09425f3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #3088   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           87        87           
  Lines        18300     18300           
  Branches      2090      2090           
=========================================
  Hits         18300     18300
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@koxudaxi koxudaxi merged commit 5137795 into koxudaxi:main Apr 16, 2026
37 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

Breaking Change Analysis

Result: No breaking changes detected

Reasoning: This PR contains three bug fixes: (1) correcting the tomli dependency marker from python_version<='3.11' to python_version<'3.11' since tomllib was added to the stdlib in 3.11, not 3.12; (2) fixing CLI input source precedence so that CLI args properly override pyproject.toml settings for competing input sources (--input, --url, --input-model); (3) fixing relative root $id resolution against the base URL in reference.py. None of these changes alter code generation output, CLI/API surface, default behaviors, template requirements, or Python version support. They are all correctness fixes for previously incorrect behavior.

This analysis was performed by Claude Code Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

🎉 Released in 0.56.1

This PR is now available in the latest release. See the release notes for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking-change-analyzed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a-detiste @koxudaxi