Fix incorrect relative imports with --use-exact-imports and --collapse-root-models by koxudaxi · Pull Request #3020 · koxudaxi/datamodel-code-generator

koxudaxi · 2026-03-03T22:52:59Z

Fixes: #3001

Summary by CodeRabbit

Release Notes

Bug Fixes
- Fixed import path resolution when using exact imports. The full import path is now correctly updated during alias resolution, preventing outdated path references.
Tests
- Added test coverage for array field titles with exact imports and root model collapsing functionality.

…e-root-models

coderabbitai · 2026-03-03T22:53:16Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 69eda18 and b213e93.

⛔ Files ignored due to path filters (2)

tests/data/jsonschema/exact_imports_collapse_root_models_title/data/ReflectionSetData.json is excluded by !tests/data/**/*.json and included by none
tests/data/jsonschema/exact_imports_collapse_root_models_title/datatypes/FooStats.json is excluded by !tests/data/**/*.json and included by none

📒 Files selected for processing (7)

src/datamodel_code_generator/parser/base.py
tests/data/expected/main/jsonschema/exact_imports_collapse_root_models_title/__init__.py
tests/data/expected/main/jsonschema/exact_imports_collapse_root_models_title/data/ReflectionSetData.py
tests/data/expected/main/jsonschema/exact_imports_collapse_root_models_title/data/__init__.py
tests/data/expected/main/jsonschema/exact_imports_collapse_root_models_title/datatypes/FooStats.py
tests/data/expected/main/jsonschema/exact_imports_collapse_root_models_title/datatypes/__init__.py
tests/main/jsonschema/test_main_jsonschema.py

📝 Walkthrough

Walkthrough

This PR fixes an import path resolution bug in the datamodel code generator. When processing data types with exact import resolution enabled, the full_path variable now correctly reflects the exact import path, ensuring consistent alias resolution throughout the generated code.

Changes

Cohort / File(s)	Summary
Core Fix `src/datamodel_code_generator/parser/base.py`	Updated `full_path` assignment to use the result of `exact_import` when processing non-base-class data types with exact import resolution, fixing incorrect relative imports with `--use-exact-imports` and `--collapse-root-models` flags.
Expected Test Output `tests/data/expected/main/jsonschema/exact_imports_collapse_root_models_title/*`	Added complete test fixture directory with generated Python package structure containing Pydantic models `ReflectionSetData` and `FooStats` with proper relative imports for exact import resolution scenarios.
Test Function `tests/main/jsonschema/test_main_jsonschema.py`	Added new test `test_main_exact_imports_collapse_root_models_title_array` that validates exact imports and root-model collapsing work correctly when array fields have titles in Pydantic v2.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Fix incorrect relative imports with --use-exact-imports and --collapse-root-models #2996: Fixes exact-import resolution in src/datamodel_code_generator/parser/base.py to ensure alias and full\_path correction when combining --use-exact-imports with --collapse-root-models.
Fix exact imports with module/class name collision #2998: Modifies import path composition in src/datamodel_code_generator/parser/base.py to ensure correct full\path/from\/import\_ computation when exact imports are enabled.
Fix aliased imports not applied to base classes and non-matching fields #2981: Applies alias resolution fixes in src/datamodel_code_generator/parser/base.py to ensure consistent aliased import usage across type references and base classes.

Suggested labels

breaking-change-analyzed

Poem

🐰 With paths exact and imports true,
The FooStats alias shines anew!
One line corrects the winding way,
No more confusion—hip hooray!
Our collapsed models hop with glee,
Now properly imported, can't you see? ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title clearly describes the main change: fixing incorrect relative imports when both --use-exact-imports and --collapse-root-models are used together.
Linked Issues check	✅ Passed	The PR implementation fixes the core issue: updating full_path in exact_import resolution ensures consistent alias usage across all type references.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the exact-imports/collapse-root-models issue: core fix in base.py and test additions confirming the fix.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/exact-imports-collapse-root-models-title

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-03-03T22:54:54Z

📚 Docs Preview: https://pr-3020.datamodel-code-generator.pages.dev

codspeed-hq · 2026-03-03T22:56:19Z

Merging this PR will not alter performance

⚠️

Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 11 untouched benchmarks
⏩ 98 skipped benchmarks¹

_{Comparing fix/exact-imports-collapse-root-models-title (b213e93) with main (69eda18)}

98 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-03-03T23:11:28Z

Breaking Change Analysis

Result: No breaking changes detected

Reasoning: This PR is a bug fix that corrects incorrect relative import path generation when using --use-exact-imports with --collapse-root-models. The previous behavior generated incorrect imports that would cause runtime import errors. While the generated code output changes, it changes from broken/incorrect to correct/working - this is a corrective fix rather than a breaking change. No CLI options, Python API, templates, or default behaviors were modified.

This analysis was performed by Claude Code Action

codecov · 2026-03-03T23:44:46Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (69eda18) to head (b213e93).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #3020   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           94        94           
  Lines        18179     18182    +3     
  Branches      2108      2108           
=========================================
+ Hits         18179     18182    +3

Flag	Coverage Δ
unittests	`100.00% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2026-03-04T04:17:17Z

🎉 Released in 0.54.1

This PR is now available in the latest release. See the release notes for details.

Fix incorrect relative imports with --use-exact-imports and --collaps…

b213e93

…e-root-models

koxudaxi merged commit 991f0ff into main Mar 3, 2026
37 checks passed

koxudaxi deleted the fix/exact-imports-collapse-root-models-title branch March 3, 2026 23:09

github-actions Bot added the breaking-change-analyzed label Mar 3, 2026

github-actions Bot mentioned this pull request Mar 4, 2026

incorrect relative imports with --use-exact-imports and --collapse-root-models - bis #3001

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix incorrect relative imports with --use-exact-imports and --collapse-root-models#3020

Fix incorrect relative imports with --use-exact-imports and --collapse-root-models#3020
koxudaxi merged 1 commit intomainfrom
fix/exact-imports-collapse-root-models-title

koxudaxi commented Mar 3, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Mar 3, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

codspeed-hq Bot commented Mar 3, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

codecov Bot commented Mar 3, 2026

Uh oh!

github-actions Bot commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

koxudaxi commented Mar 3, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Release Notes

Uh oh!

coderabbitai Bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

codspeed-hq Bot commented Mar 3, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

github-actions Bot commented Mar 3, 2026

Breaking Change Analysis

Uh oh!

codecov Bot commented Mar 3, 2026

Codecov Report

Uh oh!

github-actions Bot commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

koxudaxi commented Mar 3, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 3, 2026 •

edited

Loading