Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

src/datamodel_code_generator/arguments.py (2)

998-1005: Consider adding a type= validator for early format validation.

Without a validator, malformed entries like path/to/schema.yaml (missing the = separator) are silently accepted at parse time and only fail downstream. A lightweight validator would surface the error immediately with a clear message.

♻️ Example validator

def _external_ref_mapping(value: str) -> str:
    """Validate FILE_PATH=PYTHON_PACKAGE format."""
    if "=" not in value:
        msg = f"Invalid format {value!r}: expected 'FILE_PATH=PYTHON_PACKAGE'"
        raise ArgumentTypeError(msg)
    return value

 base_options.add_argument(
     "--external-ref-mapping",
     nargs="+",
     metavar="FILE_PATH=PYTHON_PACKAGE",
+    type=_external_ref_mapping,
     help=...,
 )

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/datamodel_code_generator/arguments.py` around lines 998 - 1005, Add a
lightweight validator function named _external_ref_mapping(value: str) that
checks for the '=' separator and raises argparse.ArgumentTypeError with a clear
message when missing, import ArgumentTypeError from argparse, and wire it into
the existing base_options.add_argument call for "--external-ref-mapping" via the
type=_external_ref_mapping parameter so malformed entries are rejected at parse
time; update the add_argument invocation to include type=_external_ref_mapping
and keep the existing nargs/metavar/help unchanged.

---

998-1005: Nit: argument is placed inside the # Schema version options section.

--external-ref-mapping is functionally a base/input option unrelated to schema versioning. Moving it above the # Schema version options comment (or after it, before the GraphQL section) would keep the section grouping meaningful.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/datamodel_code_generator/arguments.py` around lines 998 - 1005, The
--external-ref-mapping argument (added via
base_options.add_argument("--external-ref-mapping", ...)) is located inside the
"# Schema version options" block; move that add_argument call out of that
section into the base/input options area so grouping remains logical — e.g.,
relocate the base_options.add_argument for "--external-ref-mapping" above the "#
Schema version options" comment (or immediately after it but before the GraphQL
section), keeping the argument definition unchanged.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

src/datamodel_code_generator/parser/jsonschema.py (1)

1359-1366: ⚠️ Potential issue | 🟠 Major

Normalize mapped class names before building imports.

At Line [1360], the class name is taken directly from the JSON pointer fragment. This can produce invalid/mismatched imports for escaped or non-identifier schema keys (e.g., kebab-case or ~1/% escapes).

🔧 Proposed fix

-        # Extract class name from fragment (e.g., /components/schemas/SecretMetadata -> SecretMetadata)
-        class_name = fragment.rstrip("/").rsplit("/", maxsplit=1)[-1]
+        # Extract and normalize class name from JSON pointer fragment
+        raw_name = unescape_json_pointer_segment(fragment.rstrip("/").rsplit("/", maxsplit=1)[-1])
+        class_name = self.model_resolver.get_class_name(raw_name, unique=False).name
         if not class_name:
             return None
 
         # Construct import — same pattern as x-python-import
         full_path = f"{python_package}.{class_name}"

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro