Skip to content

Add deprecation warning for Pydantic v1 runtime#2833

Merged
koxudaxi merged 2 commits intomainfrom
feature/pydantic-v1-deprecation-warning
Dec 28, 2025
Merged

Add deprecation warning for Pydantic v1 runtime#2833
koxudaxi merged 2 commits intomainfrom
feature/pydantic-v1-deprecation-warning

Conversation

@koxudaxi
Copy link
Copy Markdown
Owner

@koxudaxi koxudaxi commented Dec 28, 2025 •
edited
Loading

Related Issues: #2784

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 28, 2025 •
edited
Loading

Warning

Rate limit exceeded

@koxudaxi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 34 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5ca9b4f and 904b19f.

📒 Files selected for processing (3)
  • pyproject.toml
  • src/datamodel_code_generator/__main__.py
  • tests/main/test_main_general.py
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/pydantic-v1-deprecation-warning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 28, 2025 •
edited
Loading

📚 Docs Preview: https://pr-2833.datamodel-code-generator.pages.dev

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Dec 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #2833 will not alter performance

Comparing feature/pydantic-v1-deprecation-warning (904b19f) with main (5ca9b4f)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 11 untouched
⏩ 98 skipped1

Footnotes

  1. 98 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@koxudaxi koxudaxi enabled auto-merge (squash) December 28, 2025 07:43
@koxudaxi koxudaxi merged commit 45fac78 into main Dec 28, 2025
35 checks passed
@koxudaxi koxudaxi deleted the feature/pydantic-v1-deprecation-warning branch December 28, 2025 07:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.52%. Comparing base (5ca9b4f) to head (904b19f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2833   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files          89       89           
  Lines       13964    13970    +6     
  Branches     1665     1666    +1     
=======================================
+ Hits        13897    13903    +6     
  Misses         36       36           
  Partials       31       31
Flag Coverage Δ
unittests 99.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 28, 2025

Breaking Change Analysis

Result: No breaking changes detected

Reasoning: This PR adds a deprecation warning when running with Pydantic v1, but does not change any functionality. The tool continues to work exactly as before with Pydantic v1 - users simply receive an informational DeprecationWarning. Deprecation warnings are standard Python practice for notifying users about future changes and are not considered breaking changes. The warning can be suppressed using the existing --disable-warnings flag. No code generation output, templates, API/CLI options, default behavior, or error handling has changed.

This analysis was performed by Claude Code Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 1, 2026

🎉 Released in 0.51.0

This PR is now available in the latest release. See the release notes for details.

@github-actions github-actions Bot mentioned this pull request Jan 1, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking-change-analyzed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@koxudaxi