Skip to content

Add the 'fullscreenchange' event#370

Merged
koute merged 2 commits intokoute:masterfrom
ryanisaacg:add-fullscreen-change-event
Oct 7, 2019
Merged

Add the 'fullscreenchange' event#370
koute merged 2 commits intokoute:masterfrom
ryanisaacg:add-fullscreen-change-event

Conversation

@ryanisaacg
Copy link
Copy Markdown
Contributor

No description provided.

@koute
Copy link
Copy Markdown
Owner

koute commented Sep 20, 2019

Thanks for the PR!

  1. Are you absolutely sure that the event is of type FullscreenChangeEvent? The linked specs don't seem to say anything about its type, and the MDN specifies Event as its interface. Have you checked whenever this actually works?
  2. You forgot to export it in src/lib.rs. (:

@ryanisaacg
Copy link
Copy Markdown
Contributor Author

Whoops, thanks for catching those! I've pushed fixes.

@ryanisaacg
Copy link
Copy Markdown
Contributor Author

@koute Bumping this if you have time to take a look?

ryanisaacg added a commit to ryanisaacg/winit that referenced this pull request Oct 1, 2019
@koute
Copy link
Copy Markdown
Owner

koute commented Oct 7, 2019

Sorry for the delay. Thanks!

@koute koute merged commit 6d425bc into koute:master Oct 7, 2019
@ryanisaacg
Copy link
Copy Markdown
Contributor Author

@koute If this could make it into a release as soon as it's convenient, I would appreciate it.

@koute
Copy link
Copy Markdown
Owner

koute commented Oct 10, 2019

@ryanisaacg Sure thing! Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants