Remove global mutable fields and reduce data-type related duplication#187
Merged
elect86 merged 2 commits intokotlin-graphics:1.89.2from May 17, 2023
Merged
Remove global mutable fields and reduce data-type related duplication#187elect86 merged 2 commits intokotlin-graphics:1.89.2from
elect86 merged 2 commits intokotlin-graphics:1.89.2from
Conversation
- Add Vec3Setter and Vec4Setter, function types that encode placing a value inside a VecX or FloatArray - Eliminate usage of global mutable fields like _f and _b and withX and instead use mutableReference/mutablePropertyAt - Get rid of previous erroneous MutableProperty implementation (the getter was constant, so it wouldn't reflect setter) and replace it with a factory function - Unify and rename widgetType-style functions (e.g. sliderInt) to reduce duplication - Add NumberOps interface along with associated methods to facilitate generic math operations - Remove dataTypeHelpers.kt and instead add them as functions on NumberOps - Remove PlotArray and replace it with an inline lambda - Change some KMutableProperty0 into plain values. This fixes a bug where min/max values were swapped by functions and affected the outside (Which is a misinterpretation of the C++ version. See https://replit.com/@kyay10/ImSwap-doesnt-swap-the-value-inside-pointers for explanation of ImSwap behavior) - Extract common elements of dragN, inputN, and sliderN into a widgetN function
- Fix refCol usage in colorPicker4
Collaborator
|
Thanks for the PR
That actually makes sense.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_fand_bandwithXand instead use mutableReference/mutablePropertyAtFor the future: Maybe we should also remove the overloads that take an array and a ptr and call
mutablePropertyAt? It's useless duplication because the user can just callmutablePropertyAton their own.