You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e9c0cb9
Browse filesBrowse the repository at this point in the historyBrowse files
fix(ffi): preserve aggregate null-handling support (apache#23908)
## Which issue does this PR close?
Part of apache#22331.
## Rationale for this change
`ForeignAggregateUDF` inherits the default
`supports_null_handling_clause`, so producer overrides are lost across
the FFI boundary.
## What changes are included in this PR?
- Forward `supports_null_handling_clause` through `FFI_AggregateUDF`.
- Use `first_value` as the positive case and `sum` as the negative case
in forced-foreign and dynamic-library tests.
## Are these changes tested?
- `cargo test -p datafusion-ffi --features integration-tests`
- `cargo clippy --all-targets --all-features -- -D warnings`
## Are there any user-facing changes?
The FFI ABI changes. Foreign libraries must rebuild against the new
DataFusion version.
0 commit comments