Repository navigation
Commit 9ede065
feat: add GroupColumn support for Decimal256 in multi-column GROUP BY (apache#23849)
## Which issue does this PR close?
- Part of apache#22715.
## Rationale for this change
A `Decimal256` GROUP BY key currently forces the whole grouping onto the
row-encoded `GroupValuesRows` fallback. `i256` is `Copy` and already
implements `ArrowNativeTypeOp` + `HashValue`, so it reuses the existing
`PrimitiveGroupValueBuilder`, exactly like `Decimal128`.
## What changes are included in this PR?
- Support `Decimal256` in `make_group_column` and
`group_column_supported_type`.
- Update the supported-type consistency test and add `Decimal256`
benchmark.
## Are these changes tested?
Yes, the consistency test + multi-column `Decimal256` GROUP BY (with
NULL key) in `group_by.slt`.
## Are there any user-facing changes?
No.
---------
Co-authored-by: tohuya6 <[email protected]>1 parent cdccc5a commit 9ede065
3 files changed
Lines changed: 113 additions & 3 deletions
File tree
- datafusion
- physical-plan
- benches
- src/aggregates/group_values/multi_group_by
- sqllogictest/test_files
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| |||
709 | 710 | | |
710 | 711 | | |
711 | 712 | | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
712 | 801 | | |
713 | 802 | | |
714 | 803 | | |
| |||
721 | 810 | | |
722 | 811 | | |
723 | 812 | | |
| 813 | + | |
724 | 814 | | |
725 | 815 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
951 | 951 | | |
952 | 952 | | |
953 | 953 | | |
| 954 | + | |
954 | 955 | | |
955 | 956 | | |
956 | 957 | | |
| |||
1081 | 1082 | | |
1082 | 1083 | | |
1083 | 1084 | | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
1084 | 1088 | | |
1085 | 1089 | | |
1086 | 1090 | | |
| |||
1603 | 1607 | | |
1604 | 1608 | | |
1605 | 1609 | | |
| 1610 | + | |
1606 | 1611 | | |
1607 | 1612 | | |
1608 | 1613 | | |
| |||
1640 | 1645 | | |
1641 | 1646 | | |
1642 | 1647 | | |
1643 | | - | |
1644 | 1648 | | |
1645 | 1649 | | |
1646 | 1650 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5765 | 5765 | | |
5766 | 5766 | | |
5767 | 5767 | | |
| 5768 | + | |
| 5769 | + | |
| 5770 | + | |
| 5771 | + | |
| 5772 | + | |
| 5773 | + | |
| 5774 | + | |
| 5775 | + | |
| 5776 | + | |
| 5777 | + | |
| 5778 | + | |
| 5779 | + | |
| 5780 | + | |
| 5781 | + | |
| 5782 | + | |
| 5783 | + | |
0 commit comments