Repository navigation
Commit 5f5ae01
allow range to satisfy key distribution generally (apache#23680)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->
- Closes apache#23266.
- Part of apache#22395.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
`Partitioning::Range` now satisfies `Distribution::KeyPartitioned`
privately across all operators that require it: aggregates, windows,
TopK, and co-partitioned joins. So now the temporary operator opt-ins
can be consolidated.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
- Allow compatible `Partitioning::Range` to satisfy
`Distribution::KeyPartitioned` via `Partitioning::satisfaction`
- Remove the temporary range-satisfaction helpers and operator-specific
opt-ins
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
Yes
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
No, this should not change any exisitng behavior just consolidation
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->1 parent 30278a7 commit 5f5ae01
11 files changed
Lines changed: 183 additions & 533 deletions
File tree
- datafusion
- physical-expr/src
- physical-optimizer/src
- ensure_requirements
- physical-plan/src
- aggregates
- joins
- hash_join
- sort_merge_join
- sorts
- windows
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| |||
698 | 698 | | |
699 | 699 | | |
700 | 700 | | |
701 | | - | |
702 | | - | |
703 | | - | |
704 | | - | |
705 | | - | |
706 | | - | |
707 | | - | |
708 | | - | |
709 | | - | |
710 | | - | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
711 | 707 | | |
712 | | - | |
713 | 708 | | |
714 | 709 | | |
715 | 710 | | |
| |||
722 | 717 | | |
723 | 718 | | |
724 | 719 | | |
725 | | - | |
726 | | - | |
727 | | - | |
728 | | - | |
| 720 | + | |
729 | 721 | | |
730 | | - | |
| 722 | + | |
731 | 723 | | |
732 | 724 | | |
733 | | - | |
| 725 | + | |
734 | 726 | | |
735 | 727 | | |
736 | 728 | | |
737 | | - | |
738 | | - | |
739 | | - | |
740 | | - | |
741 | | - | |
742 | | - | |
743 | 729 | | |
744 | 730 | | |
745 | 731 | | |
| |||
1308 | 1294 | | |
1309 | 1295 | | |
1310 | 1296 | | |
1311 | | - | |
| 1297 | + | |
1312 | 1298 | | |
1313 | | - | |
1314 | 1299 | | |
1315 | 1300 | | |
1316 | 1301 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
| 21 | + | |
25 | 22 | | |
26 | 23 | | |
27 | 24 | | |
| |||
161 | 158 | | |
162 | 159 | | |
163 | 160 | | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | 161 | | |
219 | 162 | | |
220 | 163 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1934 | 1934 | | |
1935 | 1935 | | |
1936 | 1936 | | |
1937 | | - | |
| 1937 | + | |
1938 | 1938 | | |
1939 | 1939 | | |
1940 | 1940 | | |
| |||
1944 | 1944 | | |
1945 | 1945 | | |
1946 | 1946 | | |
1947 | | - | |
1948 | | - | |
1949 | | - | |
1950 | | - | |
1951 | | - | |
1952 | | - | |
1953 | | - | |
1954 | | - | |
1955 | | - | |
| 1947 | + | |
1956 | 1948 | | |
1957 | 1949 | | |
1958 | 1950 | | |
| |||
0 commit comments