Repository navigation
Commit 3149072
fix: prevent incorrect results when pushing filters through anti joins (apache#24045)
## Which issue does this PR close?
- Closes apache#24002.
## Rationale for this change
Pushing filters to an anti join's non-output side can produce incorrect
results.
## What changes are included in this PR?
Restrict anti-join filter pushdown to the output side while preserving
two-sided join-key pushdown for semi joins.
## Are these changes tested?
Yes, with updated unit and SQL logic tests.
## Are there any user-facing changes?
no API changes but some downstream expected plans may change1 parent f9b7147 commit 3149072
3 files changed
Lines changed: 77 additions & 34 deletions
File tree
- datafusion
- core/tests/physical_optimizer
- physical-plan/src/joins/hash_join
- sqllogictest/test_files
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1506 | 1506 | | |
1507 | 1507 | | |
1508 | 1508 | | |
1509 | | - | |
1510 | | - | |
1511 | | - | |
1512 | | - | |
| 1509 | + | |
| 1510 | + | |
1513 | 1511 | | |
1514 | 1512 | | |
1515 | 1513 | | |
| |||
1539 | 1537 | | |
1540 | 1538 | | |
1541 | 1539 | | |
1542 | | - | |
1543 | | - | |
| 1540 | + | |
| 1541 | + | |
1544 | 1542 | | |
1545 | 1543 | | |
1546 | 1544 | | |
| |||
1579 | 1577 | | |
1580 | 1578 | | |
1581 | 1579 | | |
| 1580 | + | |
| 1581 | + | |
| 1582 | + | |
| 1583 | + | |
| 1584 | + | |
| 1585 | + | |
| 1586 | + | |
| 1587 | + | |
| 1588 | + | |
| 1589 | + | |
| 1590 | + | |
| 1591 | + | |
| 1592 | + | |
| 1593 | + | |
| 1594 | + | |
| 1595 | + | |
| 1596 | + | |
| 1597 | + | |
1582 | 1598 | | |
1583 | 1599 | | |
1584 | 1600 | | |
| |||
1817 | 1833 | | |
1818 | 1834 | | |
1819 | 1835 | | |
1820 | | - | |
| 1836 | + | |
1821 | 1837 | | |
1822 | 1838 | | |
1823 | 1839 | | |
1824 | 1840 | | |
1825 | 1841 | | |
1826 | | - | |
| 1842 | + | |
1827 | 1843 | | |
1828 | 1844 | | |
1829 | 1845 | | |
| |||
2152 | 2168 | | |
2153 | 2169 | | |
2154 | 2170 | | |
2155 | | - | |
| 2171 | + | |
2156 | 2172 | | |
2157 | 2173 | | |
2158 | 2174 | | |
| |||
2189 | 2205 | | |
2190 | 2206 | | |
2191 | 2207 | | |
2192 | | - | |
| 2208 | + | |
2193 | 2209 | | |
2194 | 2210 | | |
2195 | 2211 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1645 | 1645 | | |
1646 | 1646 | | |
1647 | 1647 | | |
1648 | | - | |
1649 | | - | |
1650 | | - | |
1651 | | - | |
1652 | | - | |
1653 | | - | |
| 1648 | + | |
| 1649 | + | |
| 1650 | + | |
1654 | 1651 | | |
1655 | | - | |
| 1652 | + | |
1656 | 1653 | | |
1657 | 1654 | | |
1658 | 1655 | | |
| |||
1666 | 1663 | | |
1667 | 1664 | | |
1668 | 1665 | | |
1669 | | - | |
| 1666 | + | |
1670 | 1667 | | |
1671 | 1668 | | |
1672 | 1669 | | |
| |||
1969 | 1966 | | |
1970 | 1967 | | |
1971 | 1968 | | |
1972 | | - | |
1973 | | - | |
| 1969 | + | |
| 1970 | + | |
1974 | 1971 | | |
1975 | 1972 | | |
1976 | 1973 | | |
1977 | 1974 | | |
1978 | 1975 | | |
1979 | 1976 | | |
1980 | | - | |
1981 | | - | |
1982 | | - | |
1983 | | - | |
1984 | | - | |
1985 | | - | |
1986 | | - | |
| 1977 | + | |
| 1978 | + | |
| 1979 | + | |
| 1980 | + | |
1987 | 1981 | | |
1988 | 1982 | | |
1989 | 1983 | | |
| |||
6848 | 6842 | | |
6849 | 6843 | | |
6850 | 6844 | | |
6851 | | - | |
| 6845 | + | |
6852 | 6846 | | |
6853 | 6847 | | |
6854 | | - | |
| 6848 | + | |
6855 | 6849 | | |
6856 | 6850 | | |
6857 | 6851 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
457 | 457 | | |
458 | 458 | | |
459 | 459 | | |
460 | | - | |
461 | | - | |
462 | | - | |
463 | | - | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
464 | 463 | | |
465 | 464 | | |
466 | 465 | | |
| |||
479 | 478 | | |
480 | 479 | | |
481 | 480 | | |
482 | | - | |
| 481 | + | |
483 | 482 | | |
484 | 483 | | |
485 | 484 | | |
| |||
491 | 490 | | |
492 | 491 | | |
493 | 492 | | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
494 | 527 | | |
495 | 528 | | |
496 | 529 | | |
| |||
0 commit comments