Repository navigation
Commit bb51aed
test: tighten and reorganize comment-formatter tests
Three small fixes from a self-review of the test suite:
- Move five tests that exercise formatRunComment out of the
formatInitialComment describe block into the formatRunComment
describe where they belong. The misplacement made test reports
misleading (formatInitialComment appeared to have six cases when
it has one).
- Add a multiple-targets case to comment_style: legacy. The
pre-existing test claimed to verify "per-target comments" but
only ran with a single label, so the per-target multiplicity
was never actually exercised. The new case asserts two comments
for two targets and zero updates.
- Drop the unused branchname parameter from the failed() test
helper. Nothing reads result.branchname (the formatter reads
error.branch), so the param was dead. The underlying field on
TargetResult.failed is also dead state — flagged for a separate
follow-up.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>1 parent e24e1e6 commit bb51aed
2 files changed
Lines changed: 29 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
650 | 650 | | |
651 | 651 | | |
652 | 652 | | |
653 | | - | |
| 653 | + | |
654 | 654 | | |
655 | 655 | | |
656 | 656 | | |
| |||
661 | 661 | | |
662 | 662 | | |
663 | 663 | | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
664 | 681 | | |
665 | 682 | | |
666 | 683 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | 26 | | |
28 | | - | |
| 27 | + | |
29 | 28 | | |
30 | 29 | | |
31 | 30 | | |
| |||
316 | 315 | | |
317 | 316 | | |
318 | 317 | | |
319 | | - | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | | - | |
329 | 318 | | |
330 | 319 | | |
331 | 320 | | |
| |||
384 | 373 | | |
385 | 374 | | |
386 | 375 | | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
0 commit comments