fix pinhole_model.png figure to show correct axis transformation #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarriba
approved these changes
Feb 4, 2021
Member
edgarriba
left a comment
edgarriba
left a comment
There was a problem hiding this comment.
LGTM. @YoniChechik thanks so much !
fbcotter
added a commit
to wayveai/kornia
that referenced
this pull request
Feb 23, 2021
* 'master' of github.com:wayveai/kornia: Add mode parameter to elastic_transform_2d (kornia#883) update readme badges with cpu/cuda versions doc updates for angle (kornia#879) Add mark.xfail in find_homography_dlt gradcheck (kornia#882) mark xfail for sift in gradcheck (kornia#881) fix pinhole_model figure to show correct axis transforamtion (kornia#874) Add epsilon value to rgb_to_hsv (kornia#871)
edgarriba
pushed a commit
that referenced
this pull request
May 30, 2021
edgarriba
pushed a commit
to edgarriba/kornia
that referenced
this pull request
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix pinhole_model.png figure to show correct axis transformation. Fixes #704 and fixes #860.
Status
Ready
Types of changes
PR Checklist
PR Implementer
This is a small checklist for the implementation details of this PR.
If there are any questions regarding code style or other conventions check out our
summary.
make testmake build-docsmake lintmake mypyKorniaTeam
KorniaTeam workflow
closes #IssueNumberat the bottom ifnot already in description)
Reviewer
Reviewer workflow
korniadesign conventions?