Repository navigation
fix(cli): report invalid log levels for maintenance runs - #5586
Merged
julio-lopez merged 4 commits intoSep 9, 2026
Merged
Conversation
julio-lopez
requested changes
Sep 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5586 +/- ##
==========================================
+ Coverage 75.86% 77.80% +1.93%
==========================================
Files 470 553 +83
Lines 37301 31806 -5495
==========================================
- Hits 28299 24746 -3553
+ Misses 7071 4982 -2089
- Partials 1931 2078 +147 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
julio-lopez
reviewed
Sep 9, 2026
julio-lopez
approved these changes
Sep 9, 2026
Collaborator
|
Thanks @justadityaraj |
julio-lopez
added a commit
to julio-lopez/kopia
that referenced
this pull request
Sep 18, 2026
* kopia/master: refactor(testing): check for `Scan()` errors in CLITest env (kopia#5626) refactor(testing): server control tests (kopia#5642) build(deps): bump the common-golang-dependencies group with 10 updates (kopia#5644) fix(testing): TestServerControlSocketActivated flake (kopia#5643) refactor(server): remove `tls.Config.VerifyPeerCertificate` (kopia#5637) fix(providers): wait for ssh process to exit to avoid leaving zombie processes (kopia#5558) fix(cli): mark `snapshot verify --parallel` as deprecated and no-op (kopia#5552) fix(testing): avoid clobbering storage used for t.Cleanup (kopia#5636) fix(testing): prevent panic in Azure versioned storage test (kopia#5635) build(infra): avoid persisting credentials in actions/checkout (kopia#5633) fix(cli): reject negative values for --parallel flags (kopia#5484) fix(cli): report invalid log levels for maintenance runs (kopia#5586) feat(ui): upgraded htmlui to the latest version (kopia#5630) build(deps-dev): bump electron (kopia#5631) build(deps): bump nanoid from 3.3.16 to 3.3.18 in /site in the npm_and_yarn group across 1 directory (kopia#5629) refactor(general): propagate `TLSConfigTrustingSingleCertificate` error (kopia#5628) refactor(testing): use `ContextForCleanup()` in `t.Cleanup()` (kopia#5627)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
maintenance run --safety=nonecould replace an invalid global flag error with the unrelatedunhandled safety levelmessage because the safety flag's backing value remained empty until Kingpin applied its default.Changes
Initialize the backing value to the safety flag's documented default before parser hooks run, and cover the invalid log-level path with a regression test.
User impact
Invalid log levels used with maintenance runs now report the allowed values so the flag can be corrected directly.
Verification
go test ./cli -run '^TestMaintenanceRunReportsInvalidGlobalFlag$' -count=1 -vgo test ./cli -count=1go vet -all ./cligolangci-lint run ./cli/...gopls check cli/app.go cli/command_maintenance_run_test.go