Repository navigation
fix: CRLF line endings no longer add width to a line - #2085
Merged
Merged
Conversation
split('\n') left the \r on every line, and canvas draws and measures it as a
space. Text with CRLF line endings came out one space wider: right and center
aligned lines sat off by that space, the underline ran past the text, and a
line that just fit wrapped at its last word.
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split('\n')leaves the\ron every line, and canvas measures and draws it as a space. So text with CRLF line endings, for example from a file or an API, comes out one space wider than the same text with LF. In Chromium withfontSize: 20:width()of'hello world\r\nfoo'is 101.16 instead of 95.6height()goes from 40 to 60The fix splits on
/\r?\n/.text()still returns the original string.