Repository navigation
fix: listen for drag events in the stage owner window - #2066
Merged
Merged
Conversation
Register drag listeners on the window that owns each stage so draggable nodes keep receiving move and end events when Konva is rendered in an iframe or popout window. Refs konvajs#1980
darkdi
marked this pull request as ready for review
August 21, 2026 09:32
lavrton
added a commit
that referenced
this pull request
Aug 25, 2026
Use the window the stage is rendered in - an iframe or a popout window - for drag and transform events, animation frames and visibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1980.
Konva installs its global drag listeners on the module's original
window. When a stage is rendered inside an iframe or popout window, mouse/touch move and end events are emitted by that stage's owner window instead, so dragging either does not start correctly or continues only when the pointer moves over the original window.This change registers the existing drag handlers on each stage's
ownerDocument.defaultViewthe first time a drag element is created. AWeakSetprevents duplicate listener registration while allowing closed iframe/popout windows to be collected. The original browser window is still registered at module initialization, so existing behavior is unchanged.The regression test creates a stage inside an iframe, starts a draggable rectangle, and dispatches native
mousemove/mouseupevents on the iframe window. It verifies the node moves and receivesdragendfrom that owner window.