Conversation
|
Tests say that this is ok except for geocoder_tester/world/germany/test_location_bias.csv::Erlange where now the expected result "Erlangen" comes 2nd and the 1st is "Berlin, Erlanger Straße" which is ok, due to the location bias being exactly there. Reducing the default location_bias_scale to 1.6 would fix this, not sure what we want :) Then also this would be fixed: geocoder_tester/world/test_big_cities.py::test_paris_from_new_zeland |
|
Now we have a problem for
and get a 'bahnhof' 40km away from the coordinate as first hit: Update: The best result would be "Bremen Hauptbahnhof". IMO it is a different issue: #318 |
lonvia
left a comment
There was a problem hiding this comment.
It would be good if you could document the new parameter in the README. It would be particularly interesting to know what is a sensible range to choose here.
|
|
||
| protected static HashSet<String> m_hsRequestQueryParams = new HashSet<>(Arrays.asList("lang", "q", "lon", "lat", "limit", "distance_sort", "osm_tag")); | ||
| protected static HashSet<String> m_hsRequestQueryParams = new HashSet<>(Arrays.asList("lang", "q", "lon", "lat", | ||
| "limit", "distance_sort", "osm_tag", "location_bias_scale")); |
There was a problem hiding this comment.
Can distance_sort be removed here?
There was a problem hiding this comment.
Ah, yeah had it removed locally already.
Good question. This depends a bit on the search but probably anything between 0.1 and 10 |
lonvia
left a comment
There was a problem hiding this comment.
Good to go from my side.
|
Hello, I'm trying to convert a zoom level to a location_bias_scale. Do you have an "ideal" solution? Is the new bbox parameter indirectly doing this? Thanks! |
See discussion in #296