Skip to content

Fix ES startup warnings#275

Merged
karussell merged 2 commits intokomoot:masterfrom
mfdz:fix_es_warnings
Dec 25, 2017
Merged

Fix ES startup warnings#275
karussell merged 2 commits intokomoot:masterfrom
mfdz:fix_es_warnings

Conversation

@hbruch
Copy link
Copy Markdown
Collaborator

@hbruch hbruch commented Dec 22, 2017

On startup, the following warnings are logged:

2017-12-22 18:09:22,783 [main] WARN  org.elasticsearch.bootstrap.Natives - JNA not found. native methods will be disabled.
java.lang.ClassNotFoundException: com.sun.jna.Native
	at java.net.URLClassLoader$1.run(URLClassLoader.java:372) ~[?:1.8.0_25]
...
2017-12-22 18:09:28,527 [elasticsearch[VXqt2Bb][clusterService#updateTask][T#1]] WARN  org.elasticsearch.deprecation.index.mapper.StringFieldMapper$TypeParser - The [string] field is deprecated, please use [text] or [keyword] instead on [de]
...

This PR fixes the by

  1. adding JNA dependency, which in elasticsearch release 5.5.0 still was optional (see When JNA is not found, leave the warning but don't show the stracktrace elastic/elasticsearch#13245)
  2. switching from deprecated ES mapping type "string" to "text"/"keyword".

Note: With the type migration I switched the type of the field housenumber from string/not_analyzed to text/indexed. This should fix #221 (unmatched uppercase housenumbers).

@karussell
Copy link
Copy Markdown
Collaborator

karussell commented Dec 22, 2017

Cool, thanks!

Note: With the type migration I switched the type of the field housenumber from string/not_analyzed to text/indexed. This should fix #221 (unmatched uppercase housenumbers).

Can we move this into a separate PR?

@karussell karussell added this to the 0.3.0 milestone Dec 22, 2017
@hbruch hbruch changed the title Fix ES startup warnings / Fix #221 Fix ES startup warnings Dec 23, 2017
@hbruch
Copy link
Copy Markdown
Collaborator Author

hbruch commented Dec 23, 2017

Converted the housenumber to keyword/indexed (equivalent to former string/not_analyzed). I'll submit the PR for the mentioned fix in a new PR after this PR is merged.

Concerning the failed travis build: to me it seems that it's unrelated to my commit. Is there anything I could do to make it pass?

@karussell
Copy link
Copy Markdown
Collaborator

karussell commented Dec 24, 2017

Thanks!

Re: travis build I needed to merge #273 first ...

@karussell karussell requested a review from lonvia December 24, 2017 22:44
@karussell karussell merged commit 4e8b73a into komoot:master Dec 25, 2017
@hbruch hbruch mentioned this pull request Jan 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lonvia lonvia lonvia approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

Unable to find address even if exact match

3 participants

@hbruch @karussell @lonvia