ploop.go: use pkg-config

kolyshkin · kolyshkin · commit e9aa072f516a · 2015-08-05T20:55:55.000-07:00
Instead of specifying CFLAGS and LDFLAGS, let's rely on pkg-config. Unfortunately go doesn't have a way to selectively pass --static flag to pkg-config, so if we try to build Docker statically the resulting binary will have many undefined symbols: # readelf -s bundles/1.7.1/binary/docker-1.7.1 | grep -w UND | grep -E 'xml|timer' 21029: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND xmlTextWriterWriteFormatE 21044: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND timer_create ......... This clearly shows that neither libxml2 nor librt were linked in, and the resulting binary will segfault on the first access to one of these symbols. To fix this, we have to pass --static to pkg-config. For case of dynamic linking, this is also OK but leads to so-called "overlinking" (see [1] for discussion about it). We could have used LDFLAGS=-Wl,--as-needed to fix this, but as there is no way to distinguish between LDFLAGS and LDLIBS (LDFLAGS should go before .o files, and LDLIBS should go after) we can't use --as-needed. Anyways, overlinking is probably a minor issue compared to a sudden binary segfault. Still, TODO: find a way to selectively pass --static to pkg-config Note: this requires a very recent ploop (with ploop.pc added). [1] https://wiki.mageia.org/en/Overlinking_issues_in_packaging Signed-off-by: Kir Kolyshkin <kir@openvz.org>
diff --git a/ploop.go b/ploop.go
@@ -4,8 +4,7 @@ import "strings"
 import "os/exec"
 import "sync"
 
-// #cgo CFLAGS: -D_GNU_SOURCE
-// #cgo LDFLAGS: -lploop -lxml2 -lrt
+// #cgo pkg-config: --static ploop
 // #include <ploop/libploop.h>
 import "C"
 
