Merged
Conversation
Add an additional condition to ensure square cropping is only applied when the thumbnail has a 1:1 aspect ratio, preventing incorrect cropping on non-square thumbnails.
…s.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…s.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Owner
|
@sang765 thanks for the fixes👌 |
Contributor
Author
Yay 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a UI issue where square cropping was being incorrectly applied to non-square thumbnails, leading to visual distortions. By introducing an explicit aspect ratio check, the system now ensures that square cropping is only activated when the thumbnail naturally has a 1:1 ratio, thereby enhancing the visual consistency and correctness of thumbnail displays across the application.
Highlights
Changelog
shouldApplySquareCropboolean logic within theItemThumbnailcomposable to include athumbnailRatio == 1fcheck.shouldApplySquareCropboolean logic within theLocalThumbnailcomposable to include athumbnailRatio == 1fcheck.Video
Screenrecorder-20260208-032048.mp4