native: Workaround for MonitorEnter with pending exception

kohlschuetter · kohlschuetter · commit d8c8be4db877 · 2024-07-08T18:06:32.000+02:00
Android doesn't like it when we call MonitorEnter with an exception
pending.
diff --git a/junixsocket-native/src/main/c/filedescriptors.c b/junixsocket-native/src/main/c/filedescriptors.c
@@ -234,6 +234,13 @@ int _closeFd(JNIEnv * env, jobject fd, int handle)
         return ret;
     }
 
+    // Android doesn't like it when we call MonitorEnter on a pending exception.
+    // Temporarily hold on to that exception, and throw again afterwards.
+    jthrowable throwable = (*env)->ExceptionOccurred(env);
+    if(throwable != NULL) {
+        (*env)->ExceptionClear(env);
+    }
+
     (*env)->MonitorEnter(env, fd);
     int fdHandle = _getFD(env, fd);
     _initFD(env, fd, -1);
@@ -243,6 +250,10 @@ int _closeFd(JNIEnv * env, jobject fd, int handle)
 #endif
     (*env)->MonitorExit(env, fd);
 
+    if(throwable != NULL) {
+        (*env)->Throw(env, throwable);
+    }
+
 #if defined(_WIN32)
     jboolean isSocket;
     if(handleWin > 0) {
