Add new feature: Always On Top on the anime player view.#614
Conversation
|
Add some working video Screen.Recording.2025-11-29.at.17.39.15.mov |
|
is this compatible on all platforms that mangayomi supports? I am certain iOS and some versions of Android will have trouble with this. |
|
I just checked. This only supports MacOS, Windows and Linux platforms, because of the package that you're introducing. The package you're introducing Lastly, the package itself is under migration to another native implementation, introducing it now could potentially include problems down the line. |
Always-on-top feature only for desktop platform.
The package |
| } | ||
|
|
||
| // Whether the platform support AlwaysOnTop feature. | ||
| bool _supportAlwaysOnTop() => |
There was a problem hiding this comment.
You could've used the variable _isDesktop, defined at line 60, instead.
They are essentially the same
There was a problem hiding this comment.
I just made it more concise, rather using _isDesktop, just make it more concise by making a function that simply stated what platform supported for the feature.
I have bad experience on using variable such as isMobile or isDesktop for some scenario in the past.
In some scenario, i have forced to support only on specific platform.
Its more concise if we define on what platform should a feature supported.
But if you want it too, i could change it to use _isDesktop.
|
I didn't notice that it was already being used. That changes things. Always on top is a common thing for video on android anyways. Youtube does it, and so do many apps that support videos. Nonetheless, I was only concerned with stability, not the idea. I like the idea and would love to see it as an option. |
If not mistaken, its called Picture in Picture (PiP) mode. PiP also exist on Desktop (macos). |
|
Yeah, it is indeed called picture in picture. Although, there's some work being done regarding the video player crashing heavily on linux, so this might be a while until it's merged. |
|
LGTM |
4 participants
New Feature:
User could make the player always shown in desktop.
Its not a bug, its a new feature.
I don't know whether its gonna be accepted to the main repo.
Its up to you guys.
I usually playing video while doing something else 😁.
So in my cases, i need this feature.