Skip to content

fix(research): add console.warn to silent catch blocks in research/maritime handlers#817

Closed
NewCoder3294 wants to merge 1 commit into
koala73:mainfrom
NewCoder3294:fix/research-handler-observability
Closed

fix(research): add console.warn to silent catch blocks in research/maritime handlers#817
NewCoder3294 wants to merge 1 commit into
koala73:mainfrom
NewCoder3294:fix/research-handler-observability

Conversation

@NewCoder3294

Copy link
Copy Markdown
Collaborator

Summary

  • Adds console.warn logging to 8 silent catch blocks across 4 handler files in the research and maritime modules
  • Follows the same pattern established in PR fix(intel): add console.warn to silent catch blocks for observability #807 (which covered intelligence handlers)
  • Each warning includes the handler name in brackets for grep-ability, a brief description of what failed, and the caught error object

Files modified:

  • server/worldmonitor/research/v1/list-arxiv-papers.ts — 1 catch block
  • server/worldmonitor/research/v1/list-trending-repos.ts — 3 catch blocks (primary API, fallback API, handler)
  • server/worldmonitor/research/v1/list-hackernews-items.ts — 2 catch blocks (per-item fetch, handler)
  • server/worldmonitor/maritime/v1/get-vessel-snapshot.ts — 2 catch blocks (relay fetch, handler)

No logic changes — only added logging to previously silent catch blocks.

Test plan

  • Verify TypeScript compilation passes (npm run typecheck)
  • Confirm no runtime behavior changes — all catch blocks still return the same fallback values
  • Optionally trigger a failure scenario (e.g., network timeout) and verify the warning appears in server logs

🤖 Generated with Claude Code

@vercel

vercel Bot commented Mar 2, 2026

Copy link
Copy Markdown

@NewCoder3294 is attempting to deploy a commit to the Elie Team on Vercel.

A member of the Team first needs to authorize it.

@koala73 koala73 added Ready to Merge PR is mergeable, passes checks, and adds value Low Value Trivial, unnecessary, or not aligned with project needs labels Mar 3, 2026
@SebastienMelki

Copy link
Copy Markdown
Collaborator

Closing in favor of consolidation with #807. @NewCoder3294, please create a single PR that rebases onto main and includes both the intel handler changes from #807 and the research/maritime changes from this PR. Optionally also include #833.

@koala73 — recommending close in favor of consolidated PR.

@koala73

koala73 commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Closing during backlog triage: stale since March with failing checks against current main. If this is still relevant, a fresh PR rebased on main would be welcome.

@koala73 koala73 closed this Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Low Value Trivial, unnecessary, or not aligned with project needs Ready to Merge PR is mergeable, passes checks, and adds value

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants