fix(research): add console.warn to silent catch blocks in research/maritime handlers#817
Closed
NewCoder3294 wants to merge 1 commit into
Closed
Conversation
…ritime handlers Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
@NewCoder3294 is attempting to deploy a commit to the Elie Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Mar 30, 2026
Collaborator
|
Closing in favor of consolidation with #807. @NewCoder3294, please create a single PR that rebases onto main and includes both the intel handler changes from #807 and the research/maritime changes from this PR. Optionally also include #833. @koala73 — recommending close in favor of consolidated PR. |
5 tasks
Owner
|
Closing during backlog triage: stale since March with failing checks against current main. If this is still relevant, a fresh PR rebased on main would be welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.warnlogging to 8 silent catch blocks across 4 handler files in the research and maritime modulesFiles modified:
server/worldmonitor/research/v1/list-arxiv-papers.ts— 1 catch blockserver/worldmonitor/research/v1/list-trending-repos.ts— 3 catch blocks (primary API, fallback API, handler)server/worldmonitor/research/v1/list-hackernews-items.ts— 2 catch blocks (per-item fetch, handler)server/worldmonitor/maritime/v1/get-vessel-snapshot.ts— 2 catch blocks (relay fetch, handler)No logic changes — only added logging to previously silent catch blocks.
Test plan
npm run typecheck)🤖 Generated with Claude Code