fix(intel): add console.warn to silent catch blocks for observability#807
Open
NewCoder3294 wants to merge 1 commit into
Open
fix(intel): add console.warn to silent catch blocks for observability#807NewCoder3294 wants to merge 1 commit into
NewCoder3294 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
@NewCoder3294 is attempting to deploy a commit to the Elie Team on Vercel. A member of the Team first needs to authorize it. |
3 tasks
koala73
added
Not Ready to Merge
4 tasks
Collaborator
|
@NewCoder3294 — this and #817 make identical changes (console.warn in silent catch blocks) across different modules. Please consolidate both into a single PR, rebased on main. Also consider including #833 (error message improvements) in the same batch since it follows the same observability theme. Style note: prefer console.error over console.warn for caught exceptions in server-side handlers, as they represent unexpected failures. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.warnwith handler-name prefixes (e.g.[get-country-intel-brief]) and the caught error to every previously-empty catch block across 4 filesFiles modified
server/worldmonitor/intelligence/v1/get-country-intel-brief.tsserver/worldmonitor/intelligence/v1/classify-event.tsserver/worldmonitor/intelligence/v1/get-pizzint-status.tsserver/worldmonitor/military/v1/list-military-bases.tsTest plan
npm run typecheck) — confirmed passing in pre-push hookconsole.warnin the 4 files to confirm all silent catches now log🤖 Generated with Claude Code