Skip to content

fix(news): sort PositiveNewsFeedPanel items by publication date descending#806

Open
NewCoder3294 wants to merge 1 commit into
koala73:mainfrom
NewCoder3294:fix/positive-news-sort
Open

fix(news): sort PositiveNewsFeedPanel items by publication date descending#806
NewCoder3294 wants to merge 1 commit into
koala73:mainfrom
NewCoder3294:fix/positive-news-sort

Conversation

@NewCoder3294

@NewCoder3294 NewCoder3294 commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Sorts positive news feed items by publication date descending (newest first) before rendering
  • Items with missing or invalid pubDate values are placed at the end of the list
  • Sort is applied in renderCards() so it takes effect regardless of the active category filter

Closes #107

Test plan

  • Verify that feed items appear with the most recent stories at the top
  • Switch between category filters and confirm sort order is maintained
  • Confirm items with missing dates appear at the bottom
  • Verify share button functionality still works correctly after sorting

🤖 Generated with Claude Code

@vercel

vercel Bot commented Mar 2, 2026

Copy link
Copy Markdown

@NewCoder3294 is attempting to deploy a commit to the Elie Team on Vercel.

A member of the Team first needs to authorize it.

@koala73 koala73 added Not Ready to Merge PR has conflicts, failing checks, or needs work High Value Meaningful contribution to the project labels Mar 3, 2026
@SebastienMelki

SebastienMelki commented Mar 30, 2026

Copy link
Copy Markdown
Collaborator

@NewCoder3294 — the sort logic is reasonable but this has merge conflicts (4 weeks old). Before this can move forward:

  1. Rebase on main
  2. Confirm the pubDate sort comparator handles RFC-2822 string dates correctly (or if the upstream normalizes to numeric timestamps)
  3. Consider consolidating with fix(intel): add console.warn to silent catch blocks for observability #807, fix(research): add console.warn to silent catch blocks in research/maritime handlers #817, and fix(ui): improve error message specificity in NewsPanel and PWA registration #833 — all are small fix/observability PRs opened the same day. Batching reduces reviewer overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

High Value Meaningful contribution to the project Not Ready to Merge PR has conflicts, failing checks, or needs work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Auto Sort - Time

3 participants

@NewCoder3294 @SebastienMelki @koala73