fix(renewable): replace hardcoded fallback with last-known-good data#5551
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- enforce the seven-day ceiling for in-memory renewable snapshots - exercise chart rendering with validator-valid cached data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5497.
live,cached, andunavailablestates to the panel, including cache ageThis is an alternative to #5521's disclosure-banner approach: the static fallback is deleted rather than retained and labelled.
Intent and non-goals
The intent is to preserve availability with canonical last-known-good data while failing closed when no trustworthy observation exists.
Non-goals:
Validation matrix
npm run typechecktest:datainside the sandboxtests/auth-session.test.mtsoutside the sandboxReview gates
Documentation
Not applicable. This changes an internal recovery contract and reuses the existing panel data-badge convention.
Screenshots / UI evidence
Automated rendered-DOM coverage verifies the unavailable state renders no World Bank chart and the cached state displays cache age. No durable screenshot is attached.
CI and review follow-up
Pending after publication.
Residual findings
None.