docs: add Tauri validation preflight and remediation guidance#55
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43c69e3e60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - `env | grep -E '^(HTTP_PROXY|HTTPS_PROXY|NO_PROXY)='` | ||
|
|
||
| If any of these checks fail, treat downstream desktop build failures as environment-level until the network path is fixed. |
There was a problem hiding this comment.
Make proxy preflight optional when no proxy is required
The new preflight flow treats any check failure as an environment blocker, but env | grep -E '^(HTTP_PROXY|HTTPS_PROXY|NO_PROXY)=' exits non-zero whenever those vars are unset, which is normal on networks that do not require a proxy. In that common case, this guidance will incorrectly classify healthy environments as failed and send QA down remediation paths unnecessarily; the proxy check should be explicitly conditional/optional (or non-fatal) rather than part of an unconditional "any failure" gate.
Useful? React with 👍 / 👎.
229354f
into
codex/add-tauri-v2-integration-and-configuration
Motivation
Description
docs/TAURI_VALIDATION_REPORT.mdthat recommends runningnpm ping,curl -I https://index.crates.io/, andenv | grep -E '^(HTTP_PROXY|HTTPS_PROXY|NO_PROXY)='prior to desktop builds.docs/TAURI_VALIDATION_REPORT.mdwith approved fixes (internal npm/Cargo mirrors, vendoringsrc-tauri/vendor/, and CI artifact restore).docs/RELEASE_PACKAGING.mdand cross-linked the two docs for consistent troubleshooting guidance.Testing
npm run desktop:package -- --helpwhich printed usage and returned successfully.npm pingwhich failed with403 Forbidden, demonstrating registry reachability failure.curl -I https://index.crates.io/which failed withCONNECT tunnel failed (403), demonstrating crates.io access is blocked.env | grep -E '^(HTTP_PROXY|HTTPS_PROXY|NO_PROXY)='which returned proxy environment variables and succeeded.Codex Task