Add reproducible Tauri packaging workflow for macOS/Windows with release checklist#49
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d0b23c095
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "desktop:package:windows:full": "VITE_VARIANT=full npx @tauri-apps/cli build --bundles nsis,msi", | ||
| "desktop:package:windows:tech": "VITE_VARIANT=tech npx @tauri-apps/cli build --config src-tauri/tauri.tech.conf.json --bundles nsis,msi", |
There was a problem hiding this comment.
Make Windows packaging scripts shell-compatible
The new Windows packaging commands are not runnable on a default Windows npm setup because they use POSIX-style inline env assignment (VITE_VARIANT=...). npm’s own docs state scripts are executed by cmd.exe on Windows (not /bin/sh), so npm run desktop:package:windows:full/tech will fail before invoking Tauri unless users manually change script-shell, which breaks the reproducible Windows workflow introduced in this commit.
Useful? React with 👍 / 👎.
71ccd09
into
codex/add-tauri-v2-integration-and-configuration
…ase checklist (koala73#49) ### Motivation - Provide reproducible local packaging commands for both product variants (full vs tech) across macOS and Windows. - Make signing/notarization and Authenticode flows optional and environment-driven so builds can be reproducible unsigned or signed when keys are available. - Ensure release artifacts and variant identities are documented and easy to validate on a clean machine. ### Description - Added deterministic packaging scripts to `package.json` for macOS (`.app` + `.dmg`) and Windows (`NSIS .exe` + `.msi`) for both `full` and `tech` variants and optional signed variants via environment variables. - Updated `src-tauri/tauri.conf.json` and `src-tauri/tauri.tech.conf.json` to explicitly target `app`, `dmg`, `nsis`, and `msi`, and added a Windows signing/timestamp hint (`sha256` + timestamp URL). - Added `docs/RELEASE_PACKAGING.md` containing per-OS packaging commands, optional signing/notarization env hooks, artifact output locations, and a clean-machine startup validation checklist. - Linked the new packaging guide from `README.md` and surfaced the new `npm run desktop:package:*` commands in the contributor command block. ### Testing - Verified the updated JSON files parse successfully with a `node -e` JSON parse check (succeeded). - Ran `npm run -s typecheck` (TypeScript `tsc --noEmit`) to ensure no type regressions (succeeded). ------ [Codex Task](https://chatgpt.com/codex/tasks/task_e_698ebfa41cbc8333ba9aeeab79aa8a72)
- koala73#34: Remove isProUser() guard from setupAuthWidget(). New users now see the sign-in button and can create accounts. The guard was intentionally deferred; removing it is the stated end-state. Close stale todos whose fixes already landed in prior PRs: - koala73#10: inferEntityClassFromName word-boundary regex (already in code) - koala73#11: entity key collision fix using candidateStateId (already in code) - koala73#12: priorWorldState threading to writeSimulationPackage (already in code) - koala73#13: sanitizeForPrompt on simulation builder strings (already in code) - koala73#14: allForecastIdSet Set-based lookup (already in code) - koala73#35: algorithms:['RS256'] in jwtVerify (already in auth-session.ts) - koala73#41: frameworkHash in deduct-situation cache key (already in code) - koala73#42: isCallerPremium server-side premium gate (already in code) - koala73#43: SSRF — ALLOWED_AGENTSKILLS_HOSTS + redirect:manual (already fixed) - koala73#44: sanitizeForPrompt on systemAppend before LLM (already in code) - koala73#45: systemAppend included in getCacheKey (already in code) - koala73#49: shippingStress/diseaseOutbreaks/socialVelocity in BOOTSTRAP_KEYS https://claude.ai/code/session_015fz1MvRuBJGYbgHubGEabA
Motivation
Description
package.jsonfor macOS (.app+.dmg) and Windows (NSIS .exe+.msi) for bothfullandtechvariants and optional signed variants via environment variables.src-tauri/tauri.conf.jsonandsrc-tauri/tauri.tech.conf.jsonto explicitly targetapp,dmg,nsis, andmsi, and added a Windows signing/timestamp hint (sha256+ timestamp URL).docs/RELEASE_PACKAGING.mdcontaining per-OS packaging commands, optional signing/notarization env hooks, artifact output locations, and a clean-machine startup validation checklist.README.mdand surfaced the newnpm run desktop:package:*commands in the contributor command block.Testing
node -eJSON parse check (succeeded).npm run -s typecheck(TypeScripttsc --noEmit) to ensure no type regressions (succeeded).Codex Task