fix(ci): deduplicate smoke test artifact name for dual Linux builds#431
Merged
Conversation
Both ubuntu-24.04 (x64) and ubuntu-24.04-arm (ARM64) upload a smoke test screenshot with the static name `linux-smoke-test-screenshot`. upload-artifact@v4 rejects duplicate names with 409 Conflict. Append matrix.label so each gets a unique artifact name. CI log proof: run 22452393753 shows the ARM64 "Upload smoke test screenshot" step failing on the exact artifact name collision.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Merged
facusturla
pushed a commit
to facusturla/worldmonitor
that referenced
this pull request
Feb 27, 2026
…oala73#431) Both ubuntu-24.04 (x64) and ubuntu-24.04-arm (ARM64) upload a smoke test screenshot with the static name `linux-smoke-test-screenshot`. upload-artifact@v4 rejects duplicate names with 409 Conflict. Append matrix.label so each gets a unique artifact name. CI log proof: run 22452393753 shows the ARM64 "Upload smoke test screenshot" step failing on the exact artifact name collision.
11 tasks
JameelHao
added a commit
to JameelHao/ireland-monitor
that referenced
this pull request
Mar 25, 2026
Add new Universities map layer for Ireland variant showing major universities and research institutions. New universities (9 total): - Trinity College Dublin (TCD): QS #81, Dublin - University College Dublin (UCD): QS #171, Dublin - Dublin City University (DCU): QS koala73#436, Dublin - Maynooth University: Maynooth - University College Cork (UCC): QS koala73#292, Cork - University of Galway (NUIG): QS koala73#289, Galway - University of Limerick (UL): QS koala73#431, Limerick - TU Dublin: Dublin - RCSI: Dublin Changes: - New file: src/config/variants/ireland/data/universities.ts - Add irelandUniversities to MapLayers type - Add Universities layer to DeckGLMap with academic blue (#1E40AF) - Enhanced pulse animation (1.5x radius, 2s period) - Add Legend entry '🎓 Universities' - Add popup rendering for universities - Add CompanyProfile support for university lookup - Add 'university' to CompanyTag type Closes #159
JameelHao
added a commit
to JameelHao/ireland-monitor
that referenced
this pull request
Mar 25, 2026
Add new Universities map layer for Ireland variant showing major universities and research institutions. New universities (9 total): - Trinity College Dublin (TCD): QS #81, Dublin - University College Dublin (UCD): QS #171, Dublin - Dublin City University (DCU): QS koala73#436, Dublin - Maynooth University: Maynooth - University College Cork (UCC): QS koala73#292, Cork - University of Galway (NUIG): QS koala73#289, Galway - University of Limerick (UL): QS koala73#431, Limerick - TU Dublin: Dublin - RCSI: Dublin Changes: - New file: src/config/variants/ireland/data/universities.ts - Add irelandUniversities to MapLayers type - Add Universities layer to DeckGLMap with academic blue (#1E40AF) - Enhanced pulse animation (1.5x radius, 2s period) - Add Legend entry '🎓 Universities' - Add popup rendering for universities - Add CompanyProfile support for university lookup - Add 'university' to CompanyTag type Closes #159
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ubuntu-24.04(x64) andubuntu-24.04-arm(ARM64) matrix entries run the smoke test and upload a screenshot artifact with the static namelinux-smoke-test-screenshotupload-artifact@v4rejects duplicate names with 409 Conflict (v3 merged, v4 errors)${{ matrix.label }}→linux-smoke-test-screenshot-Linux-x64/linux-smoke-test-screenshot-Linux-ARM64CI log proof from run 22452393753: the ARM64 "Upload smoke test screenshot" step fails on the exact artifact name collision.
Test plan