…#3456)

* chore(pre-push): typecheck convex/ to catch stale _generated/api.d.ts

PR #3453 review caught a missing-codegen slip: a new module under
convex/broadcast/ was committed without re-running `npx convex codegen`,
so convex/_generated/api.d.ts was stale. The pre-push gate ran
`typecheck` (root) and `typecheck:api` but not
`tsc -p convex/tsconfig.json`, so the stale-codegen import error
("Property 'backfillCanaryWaveStamps' does not exist on type
'internal.broadcast'") only surfaced in PR review.

Adds `npx tsc --noEmit -p convex/tsconfig.json || exit 1` between the
existing API typecheck and the CJS syntax check. Catches:
  - stale _generated/api.d.ts (forgotten codegen after adding a module)
  - drift between convex/schema.ts and code that reads it
  - any TS error inside convex/ that the root tsconfig's project
    references would otherwise miss

* fixup: also add convex typecheck to CI typecheck.yml workflow

PR #3456 review caught the gap: pre-push runs locally and can be
bypassed (`git push --no-verify`, direct pushes to main, CI-only
paths), so the convex typecheck addition was incomplete as a
correctness gate. CI's typecheck.yml ran only `typecheck` (root) and
`typecheck:api`, leaving stale `convex/_generated/api.d.ts` slippable
through CI without a failure.

Mirrors the pre-push step into the workflow:

  - run: npx tsc --noEmit -p convex/tsconfig.json

Same step, same exit semantics. Now both layers (local pre-push +
remote CI) catch stale codegen and any drift between
`convex/schema.ts` and code that reads it.

…ts (koala73#3453)

* chore(broadcast): backfill proLaunchWave stamps for canary-250 contacts

The 244 registrations who received yesterday's PRO-launch canary broadcast
need a wave stamp in Convex so future wave-export actions can exclude
them. Without this, the next wave-export would re-pick them and re-email.

Two pieces:

1. Schema: add `proLaunchWave?: v.string()` and
   `proLaunchWaveAssignedAt?: v.number()` to `registrations`, plus a
   `by_proLaunchWave` index for efficient unstamped-only scans at next
   wave's pick time. Both fields optional so existing rows pass schema
   validation.

2. One-shot internal action `backfillCanaryWaveStamps:backfillCanary250`:
   - Pages Resend `GET /contacts?segment_id=<canary>` (cursor-based via
     `after=<contact-id>`, max 100/page)
   - Normalizes each email (`trim().toLowerCase()` — same convention
     `registrations.normalizedEmail` uses)
   - Calls internal mutation `_stampWaveByNormalizedEmail` to look up
     and patch the matching registration
   - Reports {fetched, stamped, alreadyStamped, notFound, failed}
   - Idempotent — re-runs are no-ops on already-stamped rows
   - Masks emails in logs (Convex dashboard is observable to project
     viewers; raw waitlist addresses must never land in plaintext logs)

The full wave-export action that handles "pick N unstamped, stamp them,
push to fresh Resend segment" comes in the next PR — this PR just lays
the schema + the canary backfill so we don't accidentally re-email the
244 when the next wave runs.

Run after deploy:
  npx convex run broadcast/backfillCanaryWaveStamps:backfillCanary250

* fixup: address review on PR koala73#3453 — fix Resend URL + lint guard

P1: wrong Resend endpoint
The action built `GET /contacts?segment_id=...`. That URL exists but the
canonical per-segment listing endpoint is
`GET /segments/{segment_id}/contacts` (verified against Resend docs:
https://resend.com/docs/api-reference/segments/list-segment-contacts).
The wrong URL would have failed before stamping any rows, leaving the
244 canary contacts eligible for re-emailing in the next wave —
defeating the entire point of the backfill.

P1: lint guard flagged the per-contact catch
The `try/catch + console.error + stats.failed++` block in
`backfillCanary250` is intentional — per-contact stamp failures are
counted into `stats.failed` and surfaced in the action's return value
(the operator's visible surface for partial failures). Re-throwing
would abort the whole loop on the first failure and leave most
contacts unstamped. Convex auto-Sentry still captures the underlying
mutation throw inside the mutation itself, before it bubbles here as a
rejection.

Added `// sentry-coverage-ok:` marker INSIDE the catch body (the lint
guard checks the body, not surrounding lines) with a multi-line
rationale so the next reader doesn't undo the choice. Lint guard now
clean: 153 files --all, 2 files --diff.

* fixup: address review on PR koala73#3453 — close the wave-skip + regen api.d.ts

P1: backfill stamp not used by current export path
The schema doc claimed "future wave exports filter on
proLaunchWave === undefined", but the EXISTING audienceExport.ts (the
only exporter that exists today) skipped only on
empty/suppressed/paid — meaning a re-run against pro-launch-main
would re-pick the canary 244 (and any future stamped wave) and the
next broadcast would dupe-email them.

Extended the existing exporter:
- Added `alreadyInPriorWaveSkipped: number` to ExportStats.
- Added a per-row check: `if (row.proLaunchWave) { stats.alreadyInPriorWaveSkipped++; continue; }`.
  Sits AFTER suppressed/paid so the priority order is consistent
  (auth/permanent suppressions first, then prior-wave history).
- Both dry-run and live-mode honor the skip — operators see the
  count in the dry-run output before committing.

This makes the backfill load-bearing as advertised.

P1: stale convex codegen
Adding convex/broadcast/backfillCanaryWaveStamps.ts requires
regenerating convex/_generated/api.d.ts so the new module's
internal mutations/actions are reachable via internal.broadcast.*.
The pre-push gate runs the root + api typechecks but NOT
`tsc -p convex/tsconfig.json`, so the missing codegen slipped through.
Ran `npx convex codegen --typecheck=disable`; verified fix with
`npx tsc --noEmit -p convex/tsconfig.json` (silent / clean).

…koala73#3456)

* chore(pre-push): typecheck convex/ to catch stale _generated/api.d.ts

PR koala73#3453 review caught a missing-codegen slip: a new module under
convex/broadcast/ was committed without re-running `npx convex codegen`,
so convex/_generated/api.d.ts was stale. The pre-push gate ran
`typecheck` (root) and `typecheck:api` but not
`tsc -p convex/tsconfig.json`, so the stale-codegen import error
("Property 'backfillCanaryWaveStamps' does not exist on type
'internal.broadcast'") only surfaced in PR review.

Adds `npx tsc --noEmit -p convex/tsconfig.json || exit 1` between the
existing API typecheck and the CJS syntax check. Catches:
  - stale _generated/api.d.ts (forgotten codegen after adding a module)
  - drift between convex/schema.ts and code that reads it
  - any TS error inside convex/ that the root tsconfig's project
    references would otherwise miss

* fixup: also add convex typecheck to CI typecheck.yml workflow

PR koala73#3456 review caught the gap: pre-push runs locally and can be
bypassed (`git push --no-verify`, direct pushes to main, CI-only
paths), so the convex typecheck addition was incomplete as a
correctness gate. CI's typecheck.yml ran only `typecheck` (root) and
`typecheck:api`, leaving stale `convex/_generated/api.d.ts` slippable
through CI without a failure.

Mirrors the pre-push step into the workflow:

  - run: npx tsc --noEmit -p convex/tsconfig.json

Same step, same exit semantics. Now both layers (local pre-push +
remote CI) catch stale codegen and any drift between
`convex/schema.ts` and code that reads it.