fix(panels): Greptile P2 followups on #3364 (icons + category map)#3365
Conversation
Two P2 findings on the now-merged #3364: 1. Icon encoding inconsistency. The two new pipeline/storage entries mixed '\u{1F6E2}' + raw VS16 (U+FE0F) while every other panel in the file uses '\u{1F6E2}️'. Same runtime glyph, but mixed encoding is lint-noisy. Normalize to the escaped form. 2. PANEL_CATEGORY_MAP gap. pipeline-status, storage-facility-map and fuel-shortages were registered in FULL_PANELS + CMD+K but absent from PANEL_CATEGORY_MAP, so users browsing the settings category picker didn't see them. Add to marketsFinance alongside energy-complex. While here, close the same pre-existing gap for hormuz-tracker and energy-crisis — reviewer explicitly called these out as worth addressing together. The third P2 (spr keyword collision with oil-inventories) was fixed in commit 83de09f before the review finalised.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Greptile SummaryThis PR is a focused follow-up to #3364 with two targeted fixes: normalising icon encoding for Confidence Score: 5/5Safe to merge — both changes are correct, minimal, and well-scoped. All five panel keys added to PANEL_CATEGORY_MAP are confirmed valid in panels.ts. The icon encoding normalisation is functionally equivalent but lint-clean. No P0/P1 findings. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User opens Settings category picker] --> B{Browse marketsFinance category}
B --> C[Previously visible panels]
C --> C1[commodities]
C --> C2[energy-complex]
C --> C3[markets / economic / ...]
B --> D[Newly added panels - this PR]
D --> D1[pipeline-status]
D --> D2[storage-facility-map]
D --> D3[fuel-shortages]
D --> D4[hormuz-tracker]
D --> D5[energy-crisis]
Reviews (1): Last reviewed commit: "fix(panels): address Greptile P2 review ..." | Re-trigger Greptile |
1 participant
Summary
Follow-up to the now-merged #3364 addressing 2 of Greptile's 3 P2 findings (the third was already fixed in commit 83de09f before the review finalised).
Fixes
1. Icon encoding inconsistency
The 3 new panel entries in
src/config/commands.tsused `'\u{1F6E2}'` + raw U+FE0F variation selector while every other panel icon in the file uses the fully-escaped `'\u{1F6E2}\uFE0F'`. Same glyph at runtime, but mixed encoding is lint-noisy. Normalised.2. PANEL_CATEGORY_MAP gap
`pipeline-status`, `storage-facility-map`, `fuel-shortages` were in `FULL_PANELS` + CMD+K but absent from `PANEL_CATEGORY_MAP`, so users browsing the settings category picker couldn't find them. Added to `marketsFinance` alongside `energy-complex`.
Also closed the same pre-existing gap for `hormuz-tracker` and `energy-crisis` — reviewer explicitly flagged these as "worth addressing together."
Test plan
Context
See review thread on #3364. Part of the `docs/internal/energy-atlas-registry-expansion.md` follow-up.