Disambiguate NAVY callsign matching by origin country preference#33
Closed
koala73 wants to merge 1 commit into
Closed
Disambiguate NAVY callsign matching by origin country preference#33koala73 wants to merge 1 commit into
koala73 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
koala73
deleted the
codex/update-military-config-to-resolve-navy-overlap
branch
February 15, 2026 08:04
facusturla
pushed a commit
to facusturla/worldmonitor
that referenced
this pull request
Feb 27, 2026
…with fixes - PR koala73#33: Disambiguate NAVY callsign by origin country (US vs UK) - PR koala73#34: Use typecode fallback in determineAircraftInfo + Wingbits enrichment (guarded: only when type is still 'unknown') - PR koala73#35: Persist typeCode in enriched data (skip the broken pre-filter removal and false-positive regex from original PR) Closes koala73#33, koala73#34, koala73#35
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
^NAVYcallsign overlap between US and UK operators by preferring operator matches when the flightorigin_countryis known.Description
identifyByCallsignto accept an optionaloriginCountryparameter and prefer operator-specific patterns when the origin is provided (currently prefersrn/raffor UK andusn/usaf/usa/usmcfor USA).originCountrythrough the classification flow by updatingdetermineAircraftInfoto acceptoriginCountryand by passingoriginCountryfromisMilitaryFlightandparseOpenSkyResponse.ALL_MILITARY_CALLSIGNSlist unchanged so non-country matches still work as a fallback.src/config/military.tsandsrc/services/military-flights.ts.Testing
originCountryso the new preference logic is exercised at runtime (no test suite executed).Codex Task