Skip to content

fix: add CARTO and OpenStreetMap attribution to map#323

Merged
koala73 merged 1 commit into
mainfrom
fix/map-attribution
Feb 24, 2026
Merged

fix: add CARTO and OpenStreetMap attribution to map#323
koala73 merged 1 commit into
mainfrom
fix/map-attribution

Conversation

@koala73

@koala73 koala73 commented Feb 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds small attribution text at bottom-left of the map: © CARTO © OpenStreetMap
  • Links to CARTO attributions page and OSM copyright page
  • Styled to be unobtrusive (9px, dimmed, opacity: 0.6)
  • TomTom is not used — reporter was mistaken about that

Context

Issue #321 correctly identified that attributionControl: false was set on MapLibre, hiding required attribution for CARTO basemap tiles and OpenStreetMap data.

Closes #321

Test plan

  • Attribution visible at bottom-left of map in dark and light themes
  • Links open correct pages in new tab
  • Text doesn't overlap map controls or legend

@vercel

vercel Bot commented Feb 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
worldmonitor Ready Ready Preview, Comment Feb 24, 2026 4:15pm
worldmonitor-finance Ready Ready Preview, Comment Feb 24, 2026 4:15pm
worldmonitor-happy Ready Ready Preview, Comment Feb 24, 2026 4:15pm
worldmonitor-startup Ready Ready Preview, Comment Feb 24, 2026 4:15pm

Request Review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Adds a small attribution line at bottom-left of the map.
CARTO basemap tiles and OpenStreetMap data both require
visible attribution per their terms of service.

Closes #321
@koala73
koala73 force-pushed the fix/map-attribution branch from 9c53bf3 to e687d65 Compare February 24, 2026 16:14
@koala73
koala73 merged commit c0b35a6 into main Feb 24, 2026
1 of 5 checks passed
koala73 added a commit that referenced this pull request Feb 24, 2026
## What's Changed

### Performance
- perf: defer YouTube/map init and stagger data loads to reduce blocking time (#287)

### Features
- feat: universal country detection — CII scoring for all countries (#344)
- feat: add Mexico as CII hotspot for cartel/security monitoring (#327)
- feat: add Mexico and LatAm security feeds for instability coverage (#325)
- feat: add category pills and search filter to Panels tab (#322)
- feat: consolidate settings into unified tabbed modal (#319)
- feat: add Island Times (Palau) RSS feed (#317)
- feat: add AI Flow settings popup for web-only AI provider control (#314)
- feat: optional channels with tab-based region browse UI (#295)
- feat: custom channel management (#282)
- feat: add Bild RSS feed scoped to German locale (#312)

### Bug Fixes
- fix: suppress notification sound when popup alerts are disabled
- fix: prevent entity conflation in pane summarization (#341)
- fix: add Mexico to COUNTRY_BOUNDS and COUNTRY_ALIASES (#338)
- fix: make OpenSky cache TTLs env-configurable (#333)
- fix: serialize OpenSky requests with global 429 cooldown (#332)
- fix: replace RSSHub feeds with native/Google News alternatives (#331)
- fix: OpenSky auth resilience — retry, IPv4, no negative cache on auth fail (#329)
- fix: add CARTO and OpenStreetMap attribution to map (#323)
- fix: add drag cleanup handlers and suppress click after drag-drop (#315)
- fix: replace HTML5 drag API with mouse events for WKWebView (#313)
- fix: open channel settings as inline modal instead of separate window (#311)
- fix: sync YouTube live panel mute state with native player controls (#285)
- fix: strip Ollama reasoning tokens from summaries (#299)
- fix: open external links in system browser on Tauri desktop (#297)
- fix: add User-Agent and Cloudflare 403 detection to secret validation (#296)
- fix: infra cost optimizations round 2 (#275)
- fix: enforce military bbox filtering (#284)
- fix: infrastructure cost optimizations across caching, polling, batching (#283)
- fix: circuit breaker persistent cache with safety fixes (#281)
- fix: immediately refresh stale services when tab regains focus (#277)

### Security
- Security hardening: SSRF protection, auth gating, and token generation (#343)
- Harden Railway relay auth, caching, and proxy routing (#320)
- Build/runtime hardening and dependency security updates (#286)
- fix: harden embed postMessage origin check (#302)
@koala73
koala73 deleted the fix/map-attribution branch February 25, 2026 08:02
andreteow pushed a commit to andreteow/worldmonitor-a47 that referenced this pull request Feb 25, 2026
Adds a small attribution line at bottom-left of the map.
CARTO basemap tiles and OpenStreetMap data both require
visible attribution per their terms of service.

Closes koala73#321
facusturla pushed a commit to facusturla/worldmonitor that referenced this pull request Feb 27, 2026
Adds a small attribution line at bottom-left of the map.
CARTO basemap tiles and OpenStreetMap data both require
visible attribution per their terms of service.

Closes koala73#321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attribution for carto, maplibre and TomTom

1 participant