Skip to content

Service Worker Excludes ML WASM but Still Caches 60+ MB ML JS Chunk#169

Closed
koala73 wants to merge 1 commit into
mainfrom
codex/fix-service-worker-caching-for-ml-chunk
Closed

Service Worker Excludes ML WASM but Still Caches 60+ MB ML JS Chunk#169
koala73 wants to merge 1 commit into
mainfrom
codex/fix-service-worker-caching-for-ml-chunk

Conversation

@koala73

@koala73 koala73 commented Feb 20, 2026

Copy link
Copy Markdown
Owner

globIgnoresexcludes/onnx*.wasmbut themlchunk (Xenova Transformers JS code) is still matched by/*.{js,…}` and will be precached by Workbox.
This inflates the initial service worker cache by ~60 MB, wasting bandwidth for users who never use browser ML.

@vercel

vercel Bot commented Feb 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
worldmonitor Ready Ready Preview, Comment Feb 20, 2026 4:45am
worldmonitor-finance Ready Ready Preview, Comment Feb 20, 2026 4:45am
worldmonitor-startup Ready Ready Preview, Comment Feb 20, 2026 4:45am

Request Review

@koala73 koala73 changed the title Codex-generated pull request Service Worker Excludes ML WASM but Still Caches 60+ MB ML JS Chunk Feb 20, 2026
Repository owner deleted a comment from chatgpt-codex-connector Bot Feb 20, 2026
@koala73 koala73 closed this in 6d94e5e Feb 20, 2026
@koala73
koala73 deleted the codex/fix-service-worker-caching-for-ml-chunk branch February 21, 2026 06:00
facusturla pushed a commit to facusturla/worldmonitor that referenced this pull request Feb 27, 2026
Closes koala73#169 — the `ml-*` pattern missed chunks without a hyphen,
causing ~60 MB of ML code to be precached by the service worker.
koala73 added a commit that referenced this pull request Apr 11, 2026
…riter

Resolves all 5 critical findings from the multi-agent code review of PR #2940.
End-to-end smoke test passes for all 8 regions with confidence=1.0.

P1 #166: health-seed-meta-not-in-keys-loops
  - Add regionalSnapshots to STANDALONE_KEYS in api/health.js
  - Without this, the SEED_META entry was dead wiring and the 12h staleness
    budget was unobservable. Same failure mode as the 'empty data ok keys
    bootstrap blind spot' the team has hit before.

P1 #167: oref-trigger-key-not-in-freshness-registry
  - Add relay:oref:history:v1 to FRESHNESS_REGISTRY (the canonical OREF key
    written by ais-relay, not the wrong intelligence:oref-alerts:v1 that the
    code was originally reading).
  - Update trigger-evaluator to read activeAlertCount/historyCount24h from
    the actual relay:oref:history:v1 payload shape.
  - oref_cluster trigger now fires when activeAlertCount > 10 (verified
    end-to-end against mock data).

P1 #168: zombie-freshness-registry-keys
  - Remove 4 freshness registry entries that no compute module reads:
    supply_chain:shipping_stress, energy:chokepoint-flows,
    intelligence:advisories-bootstrap, market:commodities-bootstrap.
  - These were dragging snapshot_confidence below 1.0 and wasting Redis
    pipeline reads. Add a header comment forbidding speculative entries.

P1 #169: diff-field-leaks-into-persisted-snapshot
  - Change computeSnapshot to return { snapshot, diff } separately so the
    diff is consumed locally for inferTriggerReason and never serialized
    into the persisted snapshot. The diff field was not part of the
    RegionalSnapshot type and would have broken Phase 1 proto codegen.
  - Update main() to destructure { snapshot } before persistSnapshot.

P1 #170: jsdoc-types-not-enforced-jsconfig-missing
  - Add scripts/seed-regional-snapshots.mjs and scripts/regional-snapshot/**
    to scripts/jsconfig.json's include array so tsc --checkJs validates the
    JSDoc @type annotations.
  - Add // @ts-check directive to all 14 .mjs files in the regional-snapshot
    pipeline.
  - Fix 4 type-safety bugs surfaced by enabling type-checking:
      actor-scoring: explicit ActorState[] type on local actors array; cast
        leverage_domains to ActorLeverageDomain[]; typed ActorRole return on
        inferRole.
      evidence-collector: explicit EvidenceItem[] type on local out array.
      scenario-builder: typed HORIZONS as ScenarioHorizon[] and LANE_NAMES
        as ScenarioName[].
      transmission-templates: cast tpl.affectedRegions to RegionId[] when
        building TransmissionPath objects.
  - Pre-existing seed-forecasts.mjs and _r2-storage.mjs errors (46 total)
    are not part of this PR's scope and remain untouched.

Verification
  - npx tsc --noEmit -p scripts/jsconfig.json: 0 errors in regional-snapshot files
  - npm run typecheck:all: clean
  - npm run test:data: 3946/3946 pass
  - tests/regional-snapshot.test.mjs: 50/50 pass
  - End-to-end smoke test: all 8 regions compute clean with confidence=1.0
  - Verified: oref_cluster trigger fires when activeAlertCount > 10
  - Verified: persisted snapshot has no diff field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant