fix: gate SignalModal auto-popup on findings toggle#101
Merged
Conversation
PR #97 only hid the badge itself but the SignalModal kept auto-opening on new signals. Gate all 5 automatic signalModal.show() calls behind findingsBadge.isEnabled() so disabling Intelligence Findings also suppresses the full-screen popup overlay. Closes #89 Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
thank you @SebastienMelki |
facusturla
pushed a commit
to facusturla/worldmonitor
that referenced
this pull request
Feb 27, 2026
## Summary - PR koala73#97 hid the badge but the `SignalModal` kept auto-opening on new signals — this is what the reporter was still seeing - Gates all 5 automatic `this.signalModal?.show()` calls behind `this.findingsBadge?.isEnabled()` so disabling Intelligence Findings also suppresses the full-screen popup overlay and sounds - Signal history is still recorded (`addToSignalHistory`) even when popup is suppressed, so re-enabling the toggle shows them Closes koala73#89 ## Test plan - [x] Disable Intelligence Findings via PANELS toggle or right-click - [x] Wait for signal refresh cycle — no full-screen popup should appear - [x] Re-enable → popups resume on next signal detection - [x] Build succeeds with no type errors 🤖 Generated with [Claude Code](https://claude.com/claude-code)
lspassos1
added a commit
to lspassos1/WD
that referenced
this pull request
Mar 11, 2026
lspassos1
added a commit
to lspassos1/WD
that referenced
this pull request
Mar 11, 2026
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SignalModalkept auto-opening on new signals — this is what the reporter was still seeingthis.signalModal?.show()calls behindthis.findingsBadge?.isEnabled()so disabling Intelligence Findings also suppresses the full-screen popup overlay and soundsaddToSignalHistory) even when popup is suppressed, so re-enabling the toggle shows themCloses #89
Test plan
🤖 Generated with Claude Code