Skip to content

Chore: Add pathIsRegexp option to docs, revert new trailing option as unneeded#190

Merged
titanism merged 1 commit intokoajs:masterfrom
harryby1149:update-docs-with-new-path-opts
Sep 13, 2024
Merged

Chore: Add pathIsRegexp option to docs, revert new trailing option as unneeded#190
titanism merged 1 commit intokoajs:masterfrom
harryby1149:update-docs-with-new-path-opts

Conversation

@harryby1149
Copy link
Copy Markdown
Contributor

@harryby1149 harryby1149 commented Sep 13, 2024

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@titanism @3imed-jaberi PR to add new options to docs. Apologies, on reading through this again I realized we don't need to add a new "trailing" option. That trailing option comes from path-to-regexp, but is really just renaming the old strict option. Instead of handling them separately, we should add the trailing option to the Layer options Object, preserving the interface for end users.

@titanism titanism merged commit 5ce4e19 into koajs:master Sep 13, 2024
@titanism
Copy link
Copy Markdown
Contributor

v13.0.1 released https://github.com/koajs/router/releases/tag/v13.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants