Chore: Add pathIsRegexp option to docs, revert new trailing option as unneeded#190
Merged
titanism merged 1 commit intokoajs:masterfrom Sep 13, 2024
Merged
Conversation
Contributor
3imed-jaberi
pushed a commit
that referenced
this pull request
Sep 17, 2024
3imed-jaberi
pushed a commit
that referenced
this pull request
Sep 18, 2024
3imed-jaberi
pushed a commit
that referenced
this pull request
Aug 2, 2025
3imed-jaberi
pushed a commit
that referenced
this pull request
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
@titanism @3imed-jaberi PR to add new options to docs. Apologies, on reading through this again I realized we don't need to add a new "trailing" option. That trailing option comes from path-to-regexp, but is really just renaming the old strict option. Instead of handling them separately, we should add the trailing option to the Layer options Object, preserving the interface for end users.