test: Remove unused Check* default constructors

MarcoFalke · MarcoFalke · commit fae349076db0 · 2023-03-22T12:37:07.000+01:00
diff --git a/src/test/checkqueue_tests.cpp b/src/test/checkqueue_tests.cpp
@@ -57,7 +57,6 @@ struct FakeCheckCheckCompletion {
 struct FailingCheck {
     bool fails;
     FailingCheck(bool _fails) : fails(_fails){};
-    FailingCheck() : fails(true){};
     bool operator()() const
     {
         return !fails;
@@ -69,7 +68,6 @@ struct UniqueCheck {
     static std::unordered_multiset<size_t> results GUARDED_BY(m);
     size_t check_id;
     UniqueCheck(size_t check_id_in) : check_id(check_id_in){};
-    UniqueCheck() : check_id(0){};
     bool operator()()
     {
         LOCK(m);
@@ -86,7 +84,6 @@ struct MemoryCheck {
     {
         return true;
     }
-    MemoryCheck() = default;
     MemoryCheck(const MemoryCheck& x)
     {
         // We have to do this to make sure that destructor calls are paired
@@ -176,9 +173,7 @@ static void Correct_Queue_range(std::vector<size_t> range)
             control.Add(std::move(vChecks));
         }
         BOOST_REQUIRE(control.Wait());
-        if (FakeCheckCheckCompletion::n_calls != i) {
-            BOOST_REQUIRE_EQUAL(FakeCheckCheckCompletion::n_calls, i);
-        }
+        BOOST_REQUIRE_EQUAL(FakeCheckCheckCompletion::n_calls, i);
     }
     small_queue->StopWorkerThreads();
 }

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,6 @@ struct FakeCheckCheckCompletion {`
`57`	`57`	`struct FailingCheck {`
`58`	`58`	`bool fails;`
`59`	`59`	`FailingCheck(bool _fails) : fails(_fails){};`
`60`		`- FailingCheck() : fails(true){};`
`61`	`60`	`bool operator()() const`
`62`	`61`	`{`
`63`	`62`	`return !fails;`
`@@ -69,7 +68,6 @@ struct UniqueCheck {`
`69`	`68`	`static std::unordered_multiset<size_t> results GUARDED_BY(m);`
`70`	`69`	`size_t check_id;`
`71`	`70`	`UniqueCheck(size_t check_id_in) : check_id(check_id_in){};`
`72`		`- UniqueCheck() : check_id(0){};`
`73`	`71`	`bool operator()()`
`74`	`72`	`{`
`75`	`73`	`LOCK(m);`
`@@ -86,7 +84,6 @@ struct MemoryCheck {`
`86`	`84`	`{`
`87`	`85`	`return true;`
`88`	`86`	`}`
`89`		`- MemoryCheck() = default;`
`90`	`87`	`MemoryCheck(const MemoryCheck& x)`
`91`	`88`	`{`
`92`	`89`	`// We have to do this to make sure that destructor calls are paired`
`@@ -176,9 +173,7 @@ static void Correct_Queue_range(std::vector<size_t> range)`
`176`	`173`	`control.Add(std::move(vChecks));`
`177`	`174`	`}`
`178`	`175`	`BOOST_REQUIRE(control.Wait());`
`179`		`- if (FakeCheckCheckCompletion::n_calls != i) {`
`180`		`- BOOST_REQUIRE_EQUAL(FakeCheckCheckCompletion::n_calls, i);`
`181`		`- }`
	`176`	`+ BOOST_REQUIRE_EQUAL(FakeCheckCheckCompletion::n_calls, i);`
`182`	`177`	`}`
`183`	`178`	`small_queue->StopWorkerThreads();`
`184`	`179`	`}`