rpc: Remove unused return type from appendCommand

MarcoFalke · MarcoFalke · commit fa93bc14c741 · 2020-08-14T12:37:06.000+02:00
diff --git a/src/rpc/server.cpp b/src/rpc/server.cpp
@@ -261,13 +261,11 @@ CRPCTable::CRPCTable()
     }
 }
 
-bool CRPCTable::appendCommand(const std::string& name, const CRPCCommand* pcmd)
+void CRPCTable::appendCommand(const std::string& name, const CRPCCommand* pcmd)
 {
-    if (IsRPCRunning())
-        return false;
+    CHECK_NONFATAL(!IsRPCRunning()); // Only add commands before rpc is running
 
     mapCommands[name].push_back(pcmd);
-    return true;
 }
 
 bool CRPCTable::removeCommand(const std::string& name, const CRPCCommand* pcmd)
diff --git a/src/rpc/server.h b/src/rpc/server.h
@@ -160,7 +160,7 @@ class CRPCTable
     /**
      * Appends a CRPCCommand to the dispatch table.
      *
-     * Returns false if RPC server is already running (dump concurrency protection).
+     * Precondition: RPC server is not running
      *
      * Commands with different method names but the same unique_id will
      * be considered aliases, and only the first registered method name will
@@ -169,7 +169,7 @@ class CRPCTable
      * between calls based on method name, and aliased commands can also
      * register different names, types, and numbers of parameters.
      */
-    bool appendCommand(const std::string& name, const CRPCCommand* pcmd);
+    void appendCommand(const std::string& name, const CRPCCommand* pcmd);
     bool removeCommand(const std::string& name, const CRPCCommand* pcmd);
 };
 

Original file line number	Diff line number	Diff line change
`@@ -261,13 +261,11 @@ CRPCTable::CRPCTable()`
`261`	`261`	`}`
`262`	`262`	`}`
`263`	`263`
`264`		`-bool CRPCTable::appendCommand(const std::string& name, const CRPCCommand* pcmd)`
	`264`	`+void CRPCTable::appendCommand(const std::string& name, const CRPCCommand* pcmd)`
`265`	`265`	`{`
`266`		`- if (IsRPCRunning())`
`267`		`- return false;`
	`266`	`+ CHECK_NONFATAL(!IsRPCRunning()); // Only add commands before rpc is running`
`268`	`267`
`269`	`268`	`mapCommands[name].push_back(pcmd);`
`270`		`- return true;`
`271`	`269`	`}`
`272`	`270`
`273`	`271`	`bool CRPCTable::removeCommand(const std::string& name, const CRPCCommand* pcmd)`