Fix initialization error when using default blockfilterindex value

PastaPastaPasta · PastaPastaPasta · commit ef2a1e3d2afb · 2025-07-16T01:08:23.000-05:00
When blockfilterindex defaults to "basic" but no explicit command line
argument is provided, GetArgs("-blockfilterindex") returns an empty vector.
This caused the validation logic to fail with "Cannot set -peerblockfilters
without -blockfilterindex" error.

Add check for empty names vector and use the default value when needed.
diff --git a/src/init.cpp b/src/init.cpp
@@ -1143,7 +1143,11 @@ bool AppInitParameterInteraction(const ArgsManager& args)
     if (blockfilterindex_value == "" || blockfilterindex_value == "1") {
         g_enabled_filter_types = AllBlockFilterTypes();
     } else if (blockfilterindex_value != "0") {
-        const std::vector<std::string> names = args.GetArgs("-blockfilterindex");
+        std::vector<std::string> names = args.GetArgs("-blockfilterindex");
+        if (names.empty()) {
+            // Use default value when no explicit -blockfilterindex was provided
+            names.push_back(DEFAULT_BLOCKFILTERINDEX);
+        }
         for (const auto& name : names) {
             BlockFilterType filter_type;
             if (!BlockFilterTypeByName(name, filter_type)) {
