Always return getpeerinfo "minfeefilter" field (for v24 backport)

jonatack · jonatack · commit 1f448542e794 · 2022-09-22T16:45:20.000+02:00
with its pre-existing v23 default value of 0.
diff --git a/src/rpc/net.cpp b/src/rpc/net.cpp
@@ -146,7 +146,7 @@ static RPCHelpMan getpeerinfo()
                     {
                         {RPCResult::Type::STR, "permission_type", Join(NET_PERMISSIONS_DOC, ",\n") + ".\n"},
                     }},
-                    {RPCResult::Type::NUM, "minfeefilter", /*optional=*/true, "The minimum fee rate for transactions this peer accepts"},
+                    {RPCResult::Type::NUM, "minfeefilter", "The minimum fee rate for transactions this peer accepts"},
                     {RPCResult::Type::OBJ_DYN, "bytessent_per_msg", "",
                     {
                         {RPCResult::Type::NUM, "msg", "The total bytes sent aggregated by message type\n"
@@ -247,9 +247,7 @@ static RPCHelpMan getpeerinfo()
             permissions.push_back(permission);
         }
         obj.pushKV("permissions", permissions);
-        if (fStateStats) {
-            obj.pushKV("minfeefilter", ValueFromAmount(statestats.m_fee_filter_received));
-        }
+        obj.pushKV("minfeefilter", fStateStats ? ValueFromAmount(statestats.m_fee_filter_received) : 0);
 
         UniValue sendPerMsgType(UniValue::VOBJ);
         for (const auto& i : stats.mapSendBytesPerMsgType) {

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ static RPCHelpMan getpeerinfo()`
`146`	`146`	`{`
`147`	`147`	`{RPCResult::Type::STR, "permission_type", Join(NET_PERMISSIONS_DOC, ",\n") + ".\n"},`
`148`	`148`	`}},`
`149`		`- {RPCResult::Type::NUM, "minfeefilter", /optional=/true, "The minimum fee rate for transactions this peer accepts"},`
	`149`	`+ {RPCResult::Type::NUM, "minfeefilter", "The minimum fee rate for transactions this peer accepts"},`
`150`	`150`	`{RPCResult::Type::OBJ_DYN, "bytessent_per_msg", "",`
`151`	`151`	`{`
`152`	`152`	`{RPCResult::Type::NUM, "msg", "The total bytes sent aggregated by message type\n"`
`@@ -247,9 +247,7 @@ static RPCHelpMan getpeerinfo()`
`247`	`247`	`permissions.push_back(permission);`
`248`	`248`	`}`
`249`	`249`	`obj.pushKV("permissions", permissions);`
`250`		`- if (fStateStats) {`
`251`		`- obj.pushKV("minfeefilter", ValueFromAmount(statestats.m_fee_filter_received));`
`252`		`- }`
	`250`	`+ obj.pushKV("minfeefilter", fStateStats ? ValueFromAmount(statestats.m_fee_filter_received) : 0);`
`253`	`251`
`254`	`252`	`UniValue sendPerMsgType(UniValue::VOBJ);`
`255`	`253`	`for (const auto& i : stats.mapSendBytesPerMsgType) {`