Repository navigation
Commit fa78ae3
fix(web): guard parseBrowserLanguages against invalid locale tags (flutter#190651)
Fixes flutter#190510
Engine bootstrap calls DomLocale(language) for every navigator.languages
entry with no validation. A bad tag (e.g. en-US@posix from Chromium when
LANG is unset) throws during field init and leaves a blank page.
Guard each tag with try/catch and skip invalid ones. If all fail, fall
back to _defaultLocale (en-US).
Tests: en-US@posix, mixed invalid+valid, empty list via
debugOverrideBrowserLanguages.
AI tools helped with drafting.
---------
Signed-off-by: Sankalp Thakur <[email protected]>
Co-authored-by: Mouad Debbar <[email protected]>1 parent e4cb8ff commit fa78ae3
2 files changed
Lines changed: 34 additions & 9 deletions
File tree
- engine/src/flutter/lib/web_ui
- lib/src/engine
- test/engine/platform_dispatcher
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1024 | 1024 | | |
1025 | 1025 | | |
1026 | 1026 | | |
1027 | | - | |
1028 | | - | |
1029 | | - | |
1030 | | - | |
1031 | | - | |
1032 | | - | |
1033 | | - | |
1034 | | - | |
| 1027 | + | |
| 1028 | + | |
| 1029 | + | |
| 1030 | + | |
| 1031 | + | |
| 1032 | + | |
| 1033 | + | |
| 1034 | + | |
| 1035 | + | |
| 1036 | + | |
| 1037 | + | |
| 1038 | + | |
1035 | 1039 | | |
1036 | 1040 | | |
1037 | | - | |
| 1041 | + | |
| 1042 | + | |
| 1043 | + | |
1038 | 1044 | | |
1039 | 1045 | | |
1040 | 1046 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
714 | 714 | | |
715 | 715 | | |
716 | 716 | | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
717 | 736 | | |
718 | 737 | | |
719 | 738 | | |
| |||
0 commit comments